Core: Make a shorthand for the rest catalog #5570
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fokko
commented
Aug 18, 2022
| public static final String ICEBERG_CATALOG_TYPE_REST = "rest"; | ||
|
|
||
| public static final String ICEBERG_CATALOG_HADOOP = "org.apache.iceberg.hadoop.HadoopCatalog"; | ||
| public static final String ICEBERG_CATALOG_HIVE = "org.apache.iceberg.hive.HiveCatalog"; |
Contributor
Author
There was a problem hiding this comment.
I had to swap this one, to fix the order.
Fokko
force-pushed
the
fd-make-a-shorthand
branch
from
66c94a5 to
73c85b9
Compare
nastra
approved these changes
Aug 18, 2022
rdblue
approved these changes
Aug 19, 2022
Fokko
added a commit
to apache/iceberg-python
that referenced
this pull request
Aug 6, 2025
Add this wayyyy back: apache/iceberg#5570
kevinjqliu
pushed a commit
to apache/iceberg-python
that referenced
this pull request
Aug 6, 2025
# Rationale for this change Added this wayyyy back: apache/iceberg#5570. I think this is nicer than the full Java classpath # Are these changes tested? # Are there any user-facing changes? <!-- In the case of user-facing changes, please add the changelog label. -->
gabeiglio
pushed a commit
to Netflix/iceberg-python
that referenced
this pull request
Aug 13, 2025
# Rationale for this change Added this wayyyy back: apache/iceberg#5570. I think this is nicer than the full Java classpath # Are these changes tested? # Are there any user-facing changes? <!-- In the case of user-facing changes, please add the changelog label. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't want to memorize the full classpath to the RESTCatalog, but now I already do. Let's make it easier for others in the future.