Skip to content
Closed
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .github/workflows/java-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,11 @@ jobs:
with:
distribution: zulu
java-version: 8
# Setup Gradle properties, heap requirements are for `:iceberg-spark:iceberg-spark-3.3_2.12:checkstyleMain`.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of updating the https://github.com/apache/iceberg/blob/master/gradle.properties, I have modified here because changing there will apply for all the tasks and other tasks doesn't have this requirement.

- name: Setup gradle.properties
run: |
mkdir -p ~/.gradle
echo "org.gradle.jvmargs=-Xmx2048m" >> ~/.gradle/gradle.properties

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about setting it here vs in gradle.properties. Curious to see what other people think about this

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't want to increase it for all the tasks. Hence added it here. I am open to others' opinions too.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am okay with a global setting, seems to be good to just have enough heap for all tasks. Is there any specific advantage for limiting to one task?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just wanted other tasks to run with a lower memory footprint (as they don't report this problem)

But as the majority is for having a global setting, I changed it to a global setting now.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once, I changed to global config. Task has failed again 😞

I don't see any log printing the gradle daemon configuration used to confirm it is using 2GB.

- run: ./gradlew -DallVersions build -x test -x javadoc -x integrationTest

build-javadoc:
Expand Down