-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Build: Increase gradle heap size #7045
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 3 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -87,6 +87,11 @@ jobs: | |
| with: | ||
| distribution: zulu | ||
| java-version: 8 | ||
| # Setup Gradle properties, heap requirements are for `:iceberg-spark:iceberg-spark-3.3_2.12:checkstyleMain`. | ||
| - name: Setup gradle.properties | ||
| run: | | ||
| mkdir -p ~/.gradle | ||
| echo "org.gradle.jvmargs=-Xmx2048m" >> ~/.gradle/gradle.properties | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm not sure about setting it here vs in
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I didn't want to increase it for all the tasks. Hence added it here. I am open to others' opinions too.
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nessie also handles this at task level
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I am okay with a global setting, seems to be good to just have enough heap for all tasks. Is there any specific advantage for limiting to one task?
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I just wanted other tasks to run with a lower memory footprint (as they don't report this problem) But as the majority is for having a global setting, I changed it to a global setting now.
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Once, I changed to global config. Task has failed again 😞 I don't see any log printing the gradle daemon configuration used to confirm it is using 2GB. |
||
| - run: ./gradlew -DallVersions build -x test -x javadoc -x integrationTest | ||
|
|
||
| build-javadoc: | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of updating the https://github.com/apache/iceberg/blob/master/gradle.properties, I have modified here because changing there will apply for all the tasks and other tasks doesn't have this requirement.