Build: Increase gradle heap size #7045
Conversation
.github/workflows/java-ci.yml
Outdated
| with: | ||
| distribution: zulu | ||
| java-version: 8 | ||
| # Setup Gradle properties, heap requirements are for `:iceberg-spark:iceberg-spark-3.3_2.12:checkstyleMain`. |
There was a problem hiding this comment.
Instead of updating the https://github.com/apache/iceberg/blob/master/gradle.properties, I have modified here because changing there will apply for all the tasks and other tasks doesn't have this requirement.
|
cc: @nastra, @jackye1995, @XN137, @Fokko |
ajantha-bhat
changed the title
.github/workflows/java-ci.yml
Outdated
| - name: Setup gradle.properties | ||
| run: | | ||
| mkdir -p ~/.gradle | ||
| echo "org.gradle.jvmargs=-Xmx2048m" >> ~/.gradle/gradle.properties |
There was a problem hiding this comment.
I'm not sure about setting it here vs in gradle.properties. Curious to see what other people think about this
There was a problem hiding this comment.
I didn't want to increase it for all the tasks. Hence added it here. I am open to others' opinions too.
There was a problem hiding this comment.
Nessie also handles this at task level
https://github.com/projectnessie/nessie/blob/ec52a296ececd612f8270c430d00690072e7e3f9/.github/workflows/pull-request-integ.yml#L93
There was a problem hiding this comment.
I am okay with a global setting, seems to be good to just have enough heap for all tasks. Is there any specific advantage for limiting to one task?
There was a problem hiding this comment.
I just wanted other tasks to run with a lower memory footprint (as they don't report this problem)
But as the majority is for having a global setting, I changed it to a global setting now.
There was a problem hiding this comment.
Once, I changed to global config. Task has failed again 😞
I don't see any log printing the gradle daemon configuration used to confirm it is using 2GB.
|
Today also people's build is failing
I think we need to merge/review this. |
ajantha-bhat
changed the title
|
closing as issue is fixed by #7321 |
3 participants
Even after bumping the checkstyle in #7024, the same error happened with the new PR which was using the updated check style version.
Fix should help in reducing/avoiding these flaky failures.
Fixes #7023