Spark 3.2: Align formatting in bucket and truncate functions #5574
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
cc @aokolnychyi |
aokolnychyi
reviewed
Aug 18, 2022
| if (input.isNullAt(NUM_BUCKETS_ORDINAL) || input.isNullAt(VALUE_ORDINAL)) { | ||
| return null; | ||
| } else { | ||
| return invoke(input.getInt(NUM_BUCKETS_ORDINAL), input.getInt(VALUE_ORDINAL)); |
Contributor
There was a problem hiding this comment.
Looks like a typo. Shall it still be input.getUTF8String()?
Contributor
Author
There was a problem hiding this comment.
Good catch. Updated!
aokolnychyi
reviewed
Aug 18, 2022
| return null; | ||
| } | ||
|
|
||
| // TODO - We can probably hash the bytes directly given they're already UTF-8 input. |
Contributor
There was a problem hiding this comment.
I'd say it is a valid TODO item. We actually have a similar optimization internally.
I think we still have this TODO in 3.3.
Contributor
Author
There was a problem hiding this comment.
You're right. We left the optimization in truncate but didn't move forward with it for bucket. My mistake.
Contributor
There was a problem hiding this comment.
Yeah, we should be able to pass the backing byte array. Let's do this in a follow-up for 3.3.
aokolnychyi
approved these changes
Aug 18, 2022
Contributor
aokolnychyi
left a comment
aokolnychyi
left a comment
There was a problem hiding this comment.
Thanks, @kbendick! I think there is one typo but looks good otherwise.
nastra
approved these changes
Aug 19, 2022
kbendick
deleted the
kb-backport-formatting-changes-to-function-catalog
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aligns formatting in TruncateFunction and BucketFunction in Spark 3.2.
It backports #5573 to Spark 3.2