Skip to content

Core: Use table partitioning with manual sort order #5187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rdblue merged 3 commits into from
Jul 7, 2022
Merged

Core: Use table partitioning with manual sort order #5187

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2ecff33
Use Table Partitioning sort with manual Sort Order in Rewrite Data Files
rajarshisarkar Jun 2, 2022
0fa6ac3
Add argument check for unsorted order.
rdblue Jul 3, 2022
f942e65
Fix error message.
rdblue Jul 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion core/src/main/java/org/apache/iceberg/actions/SortStrategy.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
import org.apache.iceberg.SortOrder;
import org.apache.iceberg.relocated.com.google.common.base.Preconditions;
import org.apache.iceberg.relocated.com.google.common.collect.ImmutableSet;
import org.apache.iceberg.util.SortOrderUtil;

/**
* A rewrite strategy for data files which aims to reorder data with data files to optimally lay them out
Expand All @@ -48,7 +49,8 @@ public abstract class SortStrategy extends BinPackStrategy {
* @return this for method chaining
*/
public SortStrategy sortOrder(SortOrder order) {
this.sortOrder = order;
Preconditions.checkArgument(!order.isUnsorted(), "Cannot set strategy sort order: unsorted");
this.sortOrder = SortOrderUtil.buildSortOrder(table(), order);
return this;
}

Expand Down