Core: Use table partitioning with manual sort order #5187
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdblue
changed the title
Contributor
|
I am confused. This PR does not seem to include all changes from #4922. Are both needed then? |
Contributor
Author
|
@aokolnychyi, I updated #4922 to fix the outstanding problems to get it into the release, but it looks like it was updated yesterday. A review would still be helpful to make sure we're happy with the change, on either PR. |
aokolnychyi
approved these changes
Jul 7, 2022
Contributor
Author
|
Thanks, @aokolnychyi! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on #4922, but adds a check for the unsorted order to make tests pass without modification.
Closes #4922.