Skip to content

edit NAMESPACE_PROPERTY_KEY to not be a reserved SQL keyword #5017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rdblue merged 2 commits into from
Jun 12, 2022
Merged

edit NAMESPACE_PROPERTY_KEY to not be a reserved SQL keyword #5017

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7543c75
edit NAMESPACE_PROPERTY_KEY to not be a reserved SQL keyword
sungwy Jun 10, 2022
c71a896
fix sqlStatement to use NAMESPACE_PROPERTY_KEY var
sungwy Jun 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions core/src/main/java/org/apache/iceberg/jdbc/JdbcUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,8 +80,8 @@ final class JdbcUtil {
// Catalog Namespace Properties
static final String NAMESPACE_PROPERTIES_TABLE_NAME = "iceberg_namespace_properties";
static final String NAMESPACE_NAME = "namespace";
static final String NAMESPACE_PROPERTY_KEY = "key";
static final String NAMESPACE_PROPERTY_VALUE = "value";
static final String NAMESPACE_PROPERTY_KEY = "property_key";
static final String NAMESPACE_PROPERTY_VALUE = "property_value";

static final String CREATE_NAMESPACE_PROPERTIES_TABLE =
"CREATE TABLE " + NAMESPACE_PROPERTIES_TABLE_NAME +
Expand Down Expand Up @@ -149,7 +149,7 @@ public static String updatePropertiesStatement(int size) {
StringBuilder sqlStatement = new StringBuilder("UPDATE " + NAMESPACE_PROPERTIES_TABLE_NAME +
" SET " + NAMESPACE_PROPERTY_VALUE + " = CASE");
for (int i = 0; i < size; i += 1) {
sqlStatement.append(" WHEN key = ? THEN ?");
sqlStatement.append(" WHEN " + NAMESPACE_PROPERTY_KEY + " = ? THEN ?");
}
sqlStatement.append(" END WHERE " + CATALOG_NAME + " = ? AND " +
NAMESPACE_NAME + " = ? AND " + NAMESPACE_PROPERTY_KEY + " IN ");
Expand Down