edit NAMESPACE_PROPERTY_KEY to not be a reserved SQL keyword#5017
Merged
rdblue merged 2 commits intoapache:masterfrom Jun 12, 2022
Merged
edit NAMESPACE_PROPERTY_KEY to not be a reserved SQL keyword#5017rdblue merged 2 commits intoapache:masterfrom
rdblue merged 2 commits intoapache:masterfrom
Conversation
Contributor
Author
Contributor
|
Running CI. |
Contributor
Author
|
Hi @rdblue I fixed an issue where one of the sqlStatements was explicitly using "key" instead of NAMESPACE_PROPERTY_KEY. Now all the tests are succeeding except for this particular one mentioned on this PR:
1552 tests completed, 1 failed, 126 skipped
|
Contributor
|
@syun64, I just merged the test fix. Running CI on this now. Thanks! |
rdblue
approved these changes
Jun 12, 2022
Contributor
|
Thanks, @syun64! |
namrathamyske
pushed a commit
to namrathamyske/iceberg
that referenced
this pull request
Jul 10, 2022
namrathamyske
pushed a commit
to namrathamyske/iceberg
that referenced
this pull request
Jul 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue reference:
#4952