Skip to content

Flink: inferred parallelism should respect global settings #4531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rdblue merged 1 commit into from
Apr 11, 2022
Merged

Flink: inferred parallelism should respect global settings #4531

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions flink/v1.14/flink/src/main/java/org/apache/iceberg/flink/source/FlinkSource.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,6 +226,9 @@ public DataStream<RowData> build() {

if (!context.isStreaming()) {
int parallelism = inferParallelism(format, context);
if (env.getMaxParallelism() > 0) {
parallelism = Math.min(parallelism, env.getMaxParallelism());
}
return env.createInput(format, typeInfo).setParallelism(parallelism);
} else {
StreamingMonitorFunction function = new StreamingMonitorFunction(tableLoader, context);
Expand Down
26 changes: 26 additions & 0 deletions flink/v1.14/flink/src/test/java/org/apache/iceberg/flink/source/TestFlinkScanSql.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
import java.util.List;
import java.util.Map;
import org.apache.flink.configuration.Configuration;
import org.apache.flink.configuration.PipelineOptions;
import org.apache.flink.table.api.EnvironmentSettings;
import org.apache.flink.table.api.TableEnvironment;
import org.apache.flink.table.api.TableResult;
Expand Down Expand Up @@ -179,6 +180,31 @@ public void testInferedParallelism() throws IOException {
Assert.assertEquals("Should produce the expected parallelism.", 1, parallelism);
}

@Test
public void testInferParallelismWithGlobalSetting() throws IOException {
Configuration cfg = tEnv.getConfig().getConfiguration();
cfg.set(PipelineOptions.MAX_PARALLELISM, 1);

Table table = catalog.createTable(TableIdentifier.of("default", "t"), TestFixtures.SCHEMA, null);

GenericAppenderHelper helper = new GenericAppenderHelper(table, fileFormat, TEMPORARY_FOLDER);
List<Record> expectedRecords = Lists.newArrayList();
long maxFileLen = 0;
for (int i = 0; i < 5; i++) {
List<Record> records = RandomGenericData.generate(TestFixtures.SCHEMA, 2, i);
DataFile dataFile = helper.writeFile(null, records);
helper.appendToTable(dataFile);
expectedRecords.addAll(records);
maxFileLen = Math.max(dataFile.fileSizeInBytes(), maxFileLen);
}

// Make sure to generate multiple CombinedScanTasks
sql("ALTER TABLE t SET ('read.split.open-file-cost'='1', 'read.split.target-size'='%s')", maxFileLen);

List<Row> results = run(null, Maps.newHashMap(), "", "*");
org.apache.iceberg.flink.TestHelpers.assertRecords(results, expectedRecords, TestFixtures.SCHEMA);
}

@Test
public void testExposeLocality() throws Exception {
Table table =
Expand Down