Skip to content

Conversation

@yittg
Copy link
Contributor

@yittg yittg commented Apr 10, 2022

The max parallelism of nodes in Flink stream graph will be set as global max parallelism if configured
we should respect it while inferring the source parallelism.

@github-actions github-actions bot added the flink label Apr 10, 2022
@yittg yittg force-pushed the fix-infer-parallelism branch 3 times, most recently from a8d1193 to c6973aa Compare April 10, 2022 02:52
@rdblue
Copy link
Contributor

rdblue commented Apr 10, 2022

Looks good to me! Just one checkstyle problem:

[ERROR] /home/runner/work/iceberg/iceberg/flink/v1.14/flink/src/test/java/org/apache/iceberg/flink/source/TestFlinkScanSql.java:192: Prefer using Lists.newArrayList() instead. [RegexpSingleline]

@yittg yittg force-pushed the fix-infer-parallelism branch from c6973aa to cc86011 Compare April 11, 2022 00:40
@rdblue rdblue merged commit 66adec7 into apache:master Apr 11, 2022
@rdblue
Copy link
Contributor

rdblue commented Apr 11, 2022

Thanks, @yittg!

@yittg yittg deleted the fix-infer-parallelism branch April 11, 2022 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants