Skip to content

Conversation

@jackye1995
Copy link
Contributor

As discussed in the mailing list: https://mail-archives.apache.org/mod_mbox/iceberg-dev/202112.mbox/%3CCAMwmD1_P2PCMpzUai5RV%2B4a9Bv62ZFqrrDdxCtLcTSvPnUxk6g%40mail.gmail.com%3E

For DefaultClientFactory, we allow configuration of S3 static credentials and endpoint.
For AssumeRoleClientFactory, we only allow configuration of S3 endpoint, because credential is always assume role credential.

@rdblue @danielcweeks @findepi @mayursrivastava

@jackye1995 jackye1995 added this to the Iceberg 0.13.0 Release milestone Dec 2, 2021
@github-actions github-actions bot added the AWS label Dec 2, 2021
@jackye1995
Copy link
Contributor Author

This is a bit hard to test, I will try to add integration tests, meanwhile @findepi @mayursrivastava could you check if the added configurations are enough for using S3FileIO in GCS, MinIO and other services?

@jackye1995
Copy link
Contributor Author

tests added, and I've run AWS integration tests to verify all tests pass.

Copy link
Contributor

@kbendick kbendick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this @jackye1995!

@rdblue
Copy link
Contributor

rdblue commented Dec 5, 2021

Looks good to me, but I'm not very familiar with this part. It would be great if @danielcweeks could take a look, too.

Copy link
Contributor

@danielcweeks danielcweeks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good to me. But for those looking to use endpoint override for GCS, I would point you to GCSFileIO #3711

@jackye1995
Copy link
Contributor Author

Thanks for the review Daniel!

For anyone looking into this, we are adding these configs for users who want to use S3 compatible storage services and frameworks such as MinIO through the AWS S3 client. But ultimately the right way to go is to have a native FileIO, like in the case of GCS, which can unlock all the features of a storage service.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants