Add FileIO implementation for Google Cloud Storage #3711
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackye1995
reviewed
Dec 10, 2021
gcp/src/main/java/org/apache/iceberg/gcp/gcs/GCSOutputStream.java
Outdated
Show resolved
Hide resolved
gcp/src/test/java/org/apache/iceberg/gcp/gcs/GCSFileIOTest.java
Outdated
Show resolved
Hide resolved
kbendick
reviewed
Dec 11, 2021
jackye1995
reviewed
Dec 12, 2021
jackye1995
approved these changes
Dec 13, 2021
Contributor
|
@danielcweeks could you provide some insights into the current thread in dev list about the bundled runtime? @openinx is starting a vote. I approved this PR assuming we will not include this to the runtime, but if we go with his option 2 we will need to mark the Google dependencies as compile only. |
Contributor
Author
|
@jackye1995 Thanks for pointing out the thread and I followed up there. For now, we don't really need to add this to the runtime, so I think what we have here is fine. We can always follow up with bundle changes if the thinking on that changes, but I wouldn't want to push that with this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds native FileIO support for GCS using the google storage apis directly.
The read/write paths leverage the streaming transfers and allow for full configuration of the storage provider via custom storage supplier. By default, a number of common configuration properties are provided via GCPProperties and can be used with a dynamically loaded configuration.