Spark: Fix ClassCastException when using bucket UDF #3368
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Related issue: #2838 |
Contributor
Author
|
@rdblue @RussellSpitzer , could you help to review this PR? :) |
rdblue
reviewed
Oct 25, 2021
| } | ||
|
|
||
| @SuppressWarnings("checkstyle:CyclomaticComplexity") | ||
| public static Object convertAtomicValue(DataType atomic, Object object) { |
Contributor
There was a problem hiding this comment.
Is this needed?
I think you could handle short and byte types by updating the convert(Type, Object) method above:
case INTEGER:
return ((Number) object).intValue();Then you wouldn't need a new method at all.
Contributor
Author
There was a problem hiding this comment.
Thanks for your review. The method is not needed.
Contributor
|
@izchen, could you fix just the latest version of Spark and then we'll port the changes to the other versions when after it is merged? That way we don't have a commit that affects all Spark versions. |
added 3 commits
October 26, 2021 00:41
Contributor
Author
|
@rdblue done, could you help to review this PR again？ |
rdblue
approved these changes
Oct 26, 2021
Contributor
|
Looks good. Thanks, @izchen! |
Contributor
Author
|
Thanks, @rdblue @jackye1995 ! |
kbendick
pushed a commit
to kbendick/iceberg
that referenced
this pull request
Oct 27, 2021
kbendick
pushed a commit
to kbendick/iceberg
that referenced
this pull request
Nov 1, 2021
rdblue
pushed a commit
that referenced
this pull request
Nov 1, 2021
wypoon
added a commit
to wypoon/iceberg
that referenced
this pull request
Nov 18, 2021
Port of apache#3368 to Spark 3.1.
wypoon
added a commit
to wypoon/iceberg
that referenced
this pull request
Nov 18, 2021
Port of apache#3368 to Spark 3.0.
wypoon
added a commit
to wypoon/iceberg
that referenced
this pull request
Nov 18, 2021
Port of apache#3368 to Spark 2.4.
This was referenced Nov 18, 2021
Initial-neko
pushed a commit
to Initial-neko/iceberg
that referenced
this pull request
Nov 23, 2021
Port of apache#3368 to Spark 3.1.
Initial-neko
pushed a commit
to Initial-neko/iceberg
that referenced
this pull request
Nov 23, 2021
Port of apache#3368 to Spark 3.0.
Initial-neko
pushed a commit
to Initial-neko/iceberg
that referenced
this pull request
Nov 23, 2021
Port of apache#3368 to Spark 2.4.
izchen
added a commit
to izchen/iceberg
that referenced
this pull request
Dec 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, directly register iceberg api
org.apache.iceberg.transforms.Bucket#applyas spark UDF inorg.apache.iceberg.spark#IcebergSpark.For byte, short, date, timestamp, and binary, Spark value of these types is different from iceberg‘s internal representation, which will cause a
ClassCastExceptionerror.We should first convert the spark value to iceberg's internal representation, and then use the converted value as the input of iceberg api
org.apache.iceberg.spark#IcebergSpark.In addition, add more ut in this PR to cover all spark atom types.