Hive: Ensure tableLevelMutex is unlocked when uncommitted metadata de… #3264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pvary
approved these changes
Oct 11, 2021
Contributor
|
Thanks for the catch and fix @jshmchenxi! |
Contributor
Author
|
@pvary Thanks for merging this! |
RussellSpitzer
pushed a commit
to RussellSpitzer/iceberg
that referenced
this pull request
Oct 29, 2021
Contributor
|
Marking this one temporarily for 0.12.1, as I've noticed that some test suites will run forever. When people go to test the release candidate, we don't want that to happen. Very open to not including it if need be. |
kbendick
pushed a commit
to kbendick/iceberg
that referenced
this pull request
Nov 1, 2021
kbendick
pushed a commit
to kbendick/iceberg
that referenced
this pull request
Nov 1, 2021
This was referenced Nov 1, 2021
rdblue
pushed a commit
that referenced
this pull request
Nov 1, 2021
Contributor
This is a correctness fix so leaving it marked for inclusion in 0.12.1. |
izchen
pushed a commit
to izchen/iceberg
that referenced
this pull request
Dec 7, 2021
Initial-neko
pushed a commit
to Initial-neko/iceberg
that referenced
this pull request
Dec 13, 2021
Initial-neko
pushed a commit
to Initial-neko/iceberg
that referenced
this pull request
Dec 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…lete fails
Simillar to #1998,
tableLevelMutexshould also be in the finally block ofcleanupMetadataAndUnlock()so that it must be unlocked.