Core : Fixing allowed null values for iceberg table properties #3052
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rawataaryan9
force-pushed
the
aman-rawat/properties-update-null-fix
branch
2 times, most recently
from
4f7a7fc to
faaba1d
Compare
rawataaryan9
force-pushed
the
aman-rawat/properties-update-null-fix
branch
from
faaba1d to
19b11df
Compare
rdblue
approved these changes
Aug 30, 2021
Contributor
|
Thanks, @rawataaryan9! Looks good. I approved this to run tests and I'll merge when they pass. |
rdblue
approved these changes
Aug 30, 2021
karuppayya
approved these changes
Aug 30, 2021
Contributor
|
Merged. I'm also marking this for inclusion in a patch release if we decide to make one. While it probably isn't reason in itself to do another release, it would be nice to fix this for people. |
kbendick
pushed a commit
to kbendick/iceberg
that referenced
this pull request
Oct 26, 2021
Co-authored-by: rawataaryan9 <[email protected]>
kbendick
pushed a commit
to kbendick/iceberg
that referenced
this pull request
Oct 27, 2021
Co-authored-by: rawataaryan9 <[email protected]>
rdblue
pushed a commit
that referenced
this pull request
Oct 29, 2021
Co-authored-by: rawataaryan9 <[email protected]>
izchen
pushed a commit
to izchen/iceberg
that referenced
this pull request
Dec 7, 2021
Co-authored-by: rawataaryan9 <[email protected]>
Initial-neko
pushed a commit
to Initial-neko/iceberg
that referenced
this pull request
Dec 13, 2021
Initial-neko
pushed a commit
to Initial-neko/iceberg
that referenced
this pull request
Dec 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current iceberg table properties by design do not support any other value than non-null string values. However, due to a typo in the code, it allows a null value for a table property. Due to this we can store the value as null but breaks the read/load of iceberg table back due to non-null property values checks as part of metadata parsers.
This PR just updates the typo to ensure we cannot populate non-null values.
@rdblue @jackye1995 @aokolnychyi @RussellSpitzer