Skip to content

Use .as() when describing an Assertion #2706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rdblue merged 1 commit into from
Jun 17, 2021
Merged

Use .as() when describing an Assertion #2706

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions api/src/test/java/org/apache/iceberg/AssertHelpers.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ public static void assertThrows(String message,
String containedInMessage,
Callable callable) {
AbstractThrowableAssert<?, ? extends Throwable> check = Assertions.assertThatThrownBy(callable::call)
.withFailMessage(message)
.as(message)
.isInstanceOf(expected);
if (null != containedInMessage) {
check.hasMessageContaining(containedInMessage);
Expand All @@ -61,7 +61,7 @@ public static void assertThrows(String message,
String containedInMessage,
Runnable runnable) {
AbstractThrowableAssert<?, ? extends Throwable> check = Assertions.assertThatThrownBy(runnable::run)
.withFailMessage(message)
.as(message)
.isInstanceOf(expected);
if (null != containedInMessage) {
check.hasMessageContaining(containedInMessage);
Expand Down Expand Up @@ -105,7 +105,7 @@ public static void assertThrowsCause(String message,
String containedInMessage,
Runnable runnable) {
Assertions.assertThatThrownBy(runnable::run)
.withFailMessage(message)
.as(message)
.getCause()
.isInstanceOf(expected)
.hasMessageContaining(containedInMessage);
Expand Down