Use .as() when describing an Assertion #2706
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`.withFailMessage(..)` was mistakenly used and was therefore overriding the actual error reporting, making debugging difficult.
jackye1995
approved these changes
Jun 17, 2021
Contributor
jackye1995
left a comment
jackye1995
left a comment
There was a problem hiding this comment.
Thanks! this error formatting looks good to me:
Expecting throwable message:
"Cannot add field unknown as an identifier field: not found in current schema or added columns"
to contain:
"not found in current schemas or added columns"
but did not.
Contributor
Author
|
@rdblue could you review/commit this please? |
rdblue
approved these changes
Jun 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.withFailMessage(..)was mistakenly used and was therefore overridingthe actual error reporting, making debugging difficult.