-
Notifications
You must be signed in to change notification settings - Fork 3k
[python] Adding Unknown and Void transforms #2697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,61 @@ | ||
| # Licensed to the Apache Software Foundation (ASF) under one | ||
| # or more contributor license agreements. See the NOTICE file | ||
| # distributed with this work for additional information | ||
| # regarding copyright ownership. The ASF licenses this file | ||
| # to you under the Apache License, Version 2.0 (the | ||
| # "License"); you may not use this file except in compliance | ||
| # with the License. You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, | ||
| # software distributed under the License is distributed on an | ||
| # "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| # KIND, either express or implied. See the License for the | ||
| # specific language governing permissions and limitations | ||
| # under the License. | ||
|
|
||
| from typing import Union | ||
|
|
||
| from iceberg.api.types import StringType, Type | ||
|
|
||
| from .transform import Transform | ||
|
|
||
|
|
||
| class UnknownTransform(Transform): | ||
|
|
||
| def __init__(self, source_type: Type, transform: str): | ||
| self.source_type = source_type | ||
| self.transform = transform | ||
|
|
||
| def apply(self, value): | ||
| raise AttributeError(f"Cannot apply unsupported transform: {self.transform}") | ||
|
|
||
| def can_transform(self, type_var) -> bool: | ||
| # assume the transform function can be applied for this type because unknown transform is only used when parsing | ||
| # a transform in an existing table. a different Iceberg version must have already validated it. | ||
| return self.source_type == type_var | ||
|
|
||
| def get_result_type(self, source_type): | ||
| # the actual result type is not known | ||
| return StringType.get() | ||
|
|
||
| def project(self, name, predicate): | ||
| return None | ||
|
|
||
| def project_strict(self, name, predicate): | ||
| return None | ||
|
|
||
| def __str__(self): | ||
| return self.transform | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This should return
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I wrote this a while back and I'm actually not sure why I overrode the Transform class |
||
|
|
||
| def __eq__(self, other: Union['UnknownTransform', Transform, object]): | ||
| if id(self) == id(other): | ||
| return True | ||
| elif not isinstance(other, UnknownTransform): | ||
| return False | ||
|
|
||
| return self.source_type == other.source_type and self.transform == other.transform | ||
|
|
||
| def __hash__(self): | ||
| return hash((self.source_type, self.transform)) | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,52 @@ | ||
| # Licensed to the Apache Software Foundation (ASF) under one | ||
| # or more contributor license agreements. See the NOTICE file | ||
| # distributed with this work for additional information | ||
| # regarding copyright ownership. The ASF licenses this file | ||
| # to you under the Apache License, Version 2.0 (the | ||
| # "License"); you may not use this file except in compliance | ||
| # with the License. You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, | ||
| # software distributed under the License is distributed on an | ||
| # "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| # KIND, either express or implied. See the License for the | ||
| # specific language governing permissions and limitations | ||
| # under the License. | ||
|
|
||
| from .transform import Transform | ||
|
|
||
|
|
||
| class VoidTransform(Transform): | ||
| _INSTANCE = None | ||
|
|
||
| @staticmethod | ||
| def get(): | ||
| if VoidTransform._INSTANCE is None: | ||
| VoidTransform._INSTANCE = VoidTransform() | ||
| return VoidTransform._INSTANCE | ||
|
|
||
| def __init__(self): | ||
| pass | ||
|
|
||
| def apply(self, value): | ||
| return None | ||
|
|
||
| def can_transform(self, type_var): | ||
| return True | ||
|
|
||
| def get_result_type(self, source_type): | ||
| return source_type | ||
|
|
||
| def project(self, name, predicate): | ||
| return None | ||
|
|
||
| def project_strict(self, name, predicate): | ||
| return None | ||
|
|
||
| def to_human_string(self, value): | ||
| return "null" | ||
|
|
||
| def __str__(self): | ||
| return "void" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar to Java implementation,
__str__should returntransform.