Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion python/iceberg/api/transforms/transforms.py
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@
from .identity import Identity
from .timestamps import Timestamps
from .truncate import Truncate
from .unknown_transform import UnknownTransform
from .void_transform import VoidTransform
from ..types import (TypeID)


Expand Down Expand Up @@ -60,7 +62,10 @@ def from_string(type_var, transform):
elif type_var.type_id == TypeID.DATE:
return Dates(transform.lower(), transform.lower())

raise RuntimeError("Unknown transform: %s" % transform)
if transform.lower() == "void":
return VoidTransform.get()

return UnknownTransform(type_var, transform)

@staticmethod
def identity(type_var):
Expand Down Expand Up @@ -109,3 +114,7 @@ def bucket(type_var, num_buckets):
@staticmethod
def truncate(type_var, width):
return Truncate.get(type_var, width)

@staticmethod
def always_null():
return VoidTransform.get()
61 changes: 61 additions & 0 deletions python/iceberg/api/transforms/unknown_transform.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,61 @@
# Licensed to the Apache Software Foundation (ASF) under one
# or more contributor license agreements. See the NOTICE file
# distributed with this work for additional information
# regarding copyright ownership. The ASF licenses this file
# to you under the Apache License, Version 2.0 (the
# "License"); you may not use this file except in compliance
# with the License. You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing,
# software distributed under the License is distributed on an
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.

from typing import Union

from iceberg.api.types import StringType, Type

from .transform import Transform


class UnknownTransform(Transform):

def __init__(self, source_type: Type, transform: str):
self.source_type = source_type
self.transform = transform
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to Java implementation, __str__ should return transform.


def apply(self, value):
raise AttributeError(f"Cannot apply unsupported transform: {self.transform}")

def can_transform(self, type_var) -> bool:
# assume the transform function can be applied for this type because unknown transform is only used when parsing
# a transform in an existing table. a different Iceberg version must have already validated it.
return self.source_type == type_var

def get_result_type(self, source_type):
# the actual result type is not known
return StringType.get()

def project(self, name, predicate):
return None

def project_strict(self, name, predicate):
return None

def __str__(self):
return self.transform
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should return value in string format instead of transform.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wrote this a while back and I'm actually not sure why I overrode the Transform class to_human_string, I just removed this since you're right that it wasn't doing the right thing.


def __eq__(self, other: Union['UnknownTransform', Transform, object]):
if id(self) == id(other):
return True
elif not isinstance(other, UnknownTransform):
return False

return self.source_type == other.source_type and self.transform == other.transform

def __hash__(self):
return hash((self.source_type, self.transform))
52 changes: 52 additions & 0 deletions python/iceberg/api/transforms/void_transform.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,52 @@
# Licensed to the Apache Software Foundation (ASF) under one
# or more contributor license agreements. See the NOTICE file
# distributed with this work for additional information
# regarding copyright ownership. The ASF licenses this file
# to you under the Apache License, Version 2.0 (the
# "License"); you may not use this file except in compliance
# with the License. You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing,
# software distributed under the License is distributed on an
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.

from .transform import Transform


class VoidTransform(Transform):
_INSTANCE = None

@staticmethod
def get():
if VoidTransform._INSTANCE is None:
VoidTransform._INSTANCE = VoidTransform()
return VoidTransform._INSTANCE

def __init__(self):
pass

def apply(self, value):
return None

def can_transform(self, type_var):
return True

def get_result_type(self, source_type):
return source_type

def project(self, name, predicate):
return None

def project_strict(self, name, predicate):
return None

def to_human_string(self, value):
return "null"

def __str__(self):
return "void"