[python] Adding Unknown and Void transforms #2697
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jun-he
reviewed
Jun 16, 2021
|
|
||
| def __init__(self, source_type: Type, transform: str): | ||
| self.source_type = source_type | ||
| self.transform = transform |
Collaborator
There was a problem hiding this comment.
Similar to Java implementation, __str__ should return transform.
| return None | ||
|
|
||
| def to_human_string(self, value) -> str: | ||
| return self.transform |
Collaborator
There was a problem hiding this comment.
This should return value in string format instead of transform.
Contributor
Author
There was a problem hiding this comment.
I wrote this a while back and I'm actually not sure why I overrode the Transform class to_human_string, I just removed this since you're right that it wasn't doing the right thing.
TGooch44
force-pushed
the
add_void_unknown_transform
branch
2 times, most recently
from
34cca87 to
c8c75a4
Compare
TGooch44
force-pushed
the
add_void_unknown_transform
branch
from
c8c75a4 to
e4fbd47
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the Void and Unknown transforms that already exists in the java implementation. It's relevant to @jun-he 's open PR.