Skip to content

Spark3: Disable catalog cache-enabled. #2659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
coolderli wants to merge 2 commits into from
Closed

Spark3: Disable catalog cache-enabled. #2659

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6384ea8
Spark3: Disable catalog cache-enabled.
coolderli Jun 2, 2021
091f875
update
coolderli Jun 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions core/src/main/java/org/apache/iceberg/CatalogProperties.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,4 +55,7 @@ private CatalogProperties() {

public static final String LOCK_TABLE = "lock.table";

public static final String CATALOG_CACHE_ENABLED = "cache-enabled";
public static final String CATALOG_CACHE_ENABLED_DEFAULT = "false";

}
2 changes: 1 addition & 1 deletion site/docs/configuration.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ Iceberg catalogs support using catalog properties to configure catalog behaviors
| warehouse | null | the root path of the data warehouse |
| uri | null | a URI string, such as Hive metastore URI |
| clients | 2 | client pool size |

| cache-enabled | false | cache catalog, only works for Spark |
Copy link
Contributor

@jshmchenxi jshmchenxi Jun 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is also a cache-enabled option in FlinkCatalogFactory. I have created a PR about this: #2648

`HadoopCatalog` and `HiveCatalog` can access the properties in their constructors.
Any other custom catalog can access the properties by implementing `Catalog.initialize(catalogName, catalogProperties)`.
The properties can be manually constructed or passed in from a compute engine like Spark or Flink.
Expand Down
4 changes: 3 additions & 1 deletion spark3/src/main/java/org/apache/iceberg/spark/SparkCatalog.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
import java.util.TreeMap;
import org.apache.hadoop.conf.Configuration;
import org.apache.iceberg.CachingCatalog;
import org.apache.iceberg.CatalogProperties;
import org.apache.iceberg.CatalogUtil;
import org.apache.iceberg.Schema;
import org.apache.iceberg.Table;
Expand Down Expand Up @@ -379,7 +380,8 @@ public boolean dropNamespace(String[] namespace) throws NoSuchNamespaceException

@Override
public final void initialize(String name, CaseInsensitiveStringMap options) {
this.cacheEnabled = Boolean.parseBoolean(options.getOrDefault("cache-enabled", "true"));
this.cacheEnabled = Boolean.parseBoolean(options.getOrDefault(CatalogProperties.CATALOG_CACHE_ENABLED,
CatalogProperties.CATALOG_CACHE_ENABLED_DEFAULT));
Catalog catalog = buildIcebergCatalog(name, options);

this.catalogName = name;
Expand Down