Docs: Add cache-enabled to catalog property list #2648
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This PR is related to this one: #2659 Though I'm not sure if cache-enabled is supported in Flink (I might be wrong). |
Contributor
Author
|
@kbendick Yes, there is also a |
rdblue
reviewed
Jun 14, 2021
site/docs/spark-configuration.md
Outdated
| | spark.sql.catalog._catalog-name_.default-namespace | default | The default current namespace for the catalog | | ||
| | spark.sql.catalog._catalog-name_.uri | thrift://host:port | Metastore connect URI; default from `hive-site.xml` | | ||
| | spark.sql.catalog._catalog-name_.warehouse | hdfs://nn:8020/warehouse/path | Base path for the warehouse directory | | ||
| | spark.sql.catalog._catalog-name_.warehouse.cache-enabled | `true` or `false` | Whether to enable catalog cache, default value is `true` | |
Contributor
There was a problem hiding this comment.
I don't think it should include warehouse.
Contributor
Author
There was a problem hiding this comment.
Yes, that was a mistake.
jshmchenxi
force-pushed
the
catalog-cache-doc
branch
from
1f375d7 to
36a35b9
Compare
jshmchenxi
force-pushed
the
catalog-cache-doc
branch
from
36a35b9 to
e8a7996
Compare
rdblue
approved these changes
Jun 15, 2021
Contributor
|
Looks great. Thanks @jshmchenxi! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default the catalog cache is enabled. In one spark-sql session, same sql over a changing iceberg table will return the same result even if the table has changed. The reason is that
loadTablemethod is cached and we couldn't get latest snapshots of the table. If we turn off the cache, we can always get the latest result within one session.So I think the
cache-enabledproperty should be in the docs as it is an important configuration.