-
Notifications
You must be signed in to change notification settings - Fork 3k
Core/Hive: Introduce total-files-size snapshot metric and populate HMS #2329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
6c83271
Core/Hive: Introduce total-files-size snapshot metric and populate HM…
marton-bod b464742
Only populate totalSize, not the rawDataSize in HMS
marton-bod dc1600e
Only set HMS stats if they're present in summary
marton-bod f85fa52
Adjust properties hive test
marton-bod File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
82 changes: 82 additions & 0 deletions
82
core/src/test/java/org/apache/iceberg/TestSnapshotSummary.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,82 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
|
|
||
| package org.apache.iceberg; | ||
|
|
||
| import java.util.Map; | ||
| import org.junit.Assert; | ||
| import org.junit.Test; | ||
| import org.junit.runner.RunWith; | ||
| import org.junit.runners.Parameterized; | ||
|
|
||
| @RunWith(Parameterized.class) | ||
| public class TestSnapshotSummary extends TableTestBase { | ||
| public TestSnapshotSummary(int formatVersion) { | ||
| super(formatVersion); | ||
| } | ||
|
|
||
| @Parameterized.Parameters(name = "formatVersion = {0}") | ||
| public static Object[] parameters() { | ||
| return new Object[] { 1, 2 }; | ||
| } | ||
|
|
||
| @Test | ||
| public void testFileSizeSummary() { | ||
| Assert.assertEquals("Table should start empty", 0, listManifestFiles().size()); | ||
|
|
||
| // fast append | ||
| table.newFastAppend() | ||
| .appendFile(FILE_A) | ||
| .commit(); | ||
| Map<String, String> summary = table.currentSnapshot().summary(); | ||
| Assert.assertEquals("10", summary.get(SnapshotSummary.ADDED_FILE_SIZE_PROP)); | ||
| Assert.assertNull(summary.get(SnapshotSummary.REMOVED_FILE_SIZE_PROP)); | ||
| Assert.assertEquals("10", summary.get(SnapshotSummary.TOTAL_FILE_SIZE_PROP)); | ||
|
|
||
| // merge append | ||
| table.newAppend() | ||
| .appendFile(FILE_B) | ||
| .commit(); | ||
| summary = table.currentSnapshot().summary(); | ||
| Assert.assertEquals("10", summary.get(SnapshotSummary.ADDED_FILE_SIZE_PROP)); | ||
| Assert.assertNull(summary.get(SnapshotSummary.REMOVED_FILE_SIZE_PROP)); | ||
| Assert.assertEquals("20", summary.get(SnapshotSummary.TOTAL_FILE_SIZE_PROP)); | ||
|
|
||
| table.newOverwrite() | ||
| .deleteFile(FILE_A) | ||
| .deleteFile(FILE_B) | ||
| .addFile(FILE_C) | ||
| .addFile(FILE_D) | ||
| .addFile(FILE_D) | ||
| .commit(); | ||
| summary = table.currentSnapshot().summary(); | ||
| Assert.assertEquals("30", summary.get(SnapshotSummary.ADDED_FILE_SIZE_PROP)); | ||
| Assert.assertEquals("20", summary.get(SnapshotSummary.REMOVED_FILE_SIZE_PROP)); | ||
| Assert.assertEquals("30", summary.get(SnapshotSummary.TOTAL_FILE_SIZE_PROP)); | ||
|
|
||
| table.newDelete() | ||
| .deleteFile(FILE_C) | ||
| .deleteFile(FILE_D) | ||
| .commit(); | ||
| summary = table.currentSnapshot().summary(); | ||
| Assert.assertNull(summary.get(SnapshotSummary.ADDED_FILE_SIZE_PROP)); | ||
| Assert.assertEquals("20", summary.get(SnapshotSummary.REMOVED_FILE_SIZE_PROP)); | ||
| Assert.assertEquals("10", summary.get(SnapshotSummary.TOTAL_FILE_SIZE_PROP)); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we remove them if we do not have summary data?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think so. For example, when we create a new table, Hive already puts numRows=0, totalSize=0, etc. into the HMS table params, so we would just end up removing those valid values here. Other than the we-just-created-the-table scenario, I think we should always have the summary object with these 3 values filled out. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense. Hope this is true: