Validate concurrent commits in DynamicIcebergSink to prevent commit duplication #14517
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 6, 2025
aiborodin
force-pushed
the
fix-commit-duplication-in-flink
branch
from
36f03a9 to
90877bf
Compare
Contributor
Author
|
@pvary, I updated this PR with the new API that was recently merged. |
pvary
reviewed
Nov 7, 2025
flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/DynamicCommitter.java
Outdated
Show resolved
Hide resolved
pvary
reviewed
Nov 7, 2025
flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/DynamicCommitter.java
Outdated
Show resolved
Hide resolved
pvary
reviewed
Nov 7, 2025
flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/DynamicCommitter.java
Outdated
Show resolved
Hide resolved
aiborodin
force-pushed
the
fix-commit-duplication-in-flink
branch
2 times, most recently
from
4be7dd5 to
46b70e5
Compare
pvary
reviewed
Nov 11, 2025
flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/DynamicCommitter.java
Outdated
Show resolved
Hide resolved
pvary
reviewed
Nov 11, 2025
flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/DynamicCommitter.java
Outdated
Show resolved
Hide resolved
pvary
reviewed
Nov 11, 2025
flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/DynamicCommitter.java
Outdated
Show resolved
Hide resolved
mxm
reviewed
Nov 11, 2025
flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/DynamicCommitter.java
Outdated
Show resolved
Hide resolved
flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/DynamicCommitter.java
Outdated
Show resolved
Hide resolved
flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/DynamicCommitter.java
Outdated
Show resolved
Hide resolved
aiborodin
force-pushed
the
fix-commit-duplication-in-flink
branch
from
46b70e5 to
be867b5
Compare
pvary
reviewed
Nov 12, 2025
.../v1.20/flink/src/test/java/org/apache/iceberg/flink/sink/dynamic/TestDynamicIcebergSink.java
Show resolved
Hide resolved
pvary
reviewed
Nov 12, 2025
flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/DynamicCommitter.java
Outdated
Show resolved
Hide resolved
pvary
reviewed
Nov 12, 2025
flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/DynamicCommitter.java
Outdated
Show resolved
Hide resolved
Contributor
|
When this is fixed, it would be good to fix this in the non-dynamic sink too. |
aiborodin
force-pushed
the
fix-commit-duplication-in-flink
branch
from
be867b5 to
6419219
Compare
Contributor
Author
Sounds good, I will raise a PR for the regular sink. |
pvary
reviewed
Nov 13, 2025
flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/DynamicCommitter.java
Outdated
Show resolved
Hide resolved
pvary
reviewed
Nov 13, 2025
flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/DynamicCommitter.java
Outdated
Show resolved
Hide resolved
aiborodin
force-pushed
the
fix-commit-duplication-in-flink
branch
from
6419219 to
279d707
Compare
aiborodin
force-pushed
the
fix-commit-duplication-in-flink
branch
3 times, most recently
from
f126e52 to
1fbacd3
Compare
Change-Id: I9df6d982ce7b32621a966bf68b1f43cb7c85c4e7
aiborodin
force-pushed
the
fix-commit-duplication-in-flink
branch
from
1fbacd3 to
87e86a8
Compare
pvary
approved these changes
Nov 19, 2025
Contributor
|
Merged to main. |
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the issue in #14425 by validating that no concurrent commit has moved the
flink.max-committed-checkpoint-idinDynamicIcebergSinkthat would not be seen by the committer due to the table refreshing during the commit process.