Flink: Refactor WriteResult aggregation in DynamicIcebergSink #14312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pvary
reviewed
Oct 13, 2025
.../flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/DynamicWriteResultAggregator.java
Show resolved
Hide resolved
pvary
reviewed
Oct 13, 2025
flink/v2.0/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/DynamicCommittable.java
Show resolved
Hide resolved
aiborodin
force-pushed
the
refactor-commit-aggregation
branch
from
5904b13 to
3b00257
Compare
aiborodin
changed the title
aiborodin
force-pushed
the
refactor-commit-aggregation
branch
2 times, most recently
from
9887fcb to
14f0c7b
Compare
DynamicWriteResultAggregator currently produces multiple committables per (table, branch, checkpoint), which get aggregated in the downstream committer. Refactor the commit aggregator to output only one committable per triplet. Clean up DynamicCommitter to remove assumptions of multiple commit requests per table, branch, and checkpoint. This requires serializing the aggregated WriteResult using multiple temporary manifest files for each unique partition spec because the Iceberg manifest writer requires a single spec per manifest file. We can improve this later by refactoring serialization in the following changes.
aiborodin
force-pushed
the
refactor-commit-aggregation
branch
from
14f0c7b to
479668f
Compare
pvary
reviewed
Oct 23, 2025
flink/v2.0/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/DynamicCommitter.java
Show resolved
Hide resolved
pvary
reviewed
Oct 23, 2025
flink/v2.0/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/DynamicCommitter.java
Show resolved
Hide resolved
pvary
reviewed
Oct 23, 2025
flink/v2.0/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/DynamicCommitter.java
Show resolved
Hide resolved
pvary
reviewed
Oct 23, 2025
flink/v2.0/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/DynamicCommitter.java
Show resolved
Hide resolved
pvary
reviewed
Oct 23, 2025
...k/v2.0/flink/src/test/java/org/apache/iceberg/flink/sink/dynamic/TestDynamicIcebergSink.java
Show resolved
Hide resolved
pvary
reviewed
Oct 23, 2025
...nk/src/test/java/org/apache/iceberg/flink/sink/dynamic/TestDynamicCommittableSerializer.java
Show resolved
Hide resolved
3 tasks
|
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions. |
|
This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time. |
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the
WriteResultaggregation logic fromDynamicCommittertoDynamicWriteResultAggregator, as described in this comment: #14182 (comment).DynamicWriteResultAggregatorcurrently produces multipleDynamicCommittablesper (table, branch, checkpoint) triplet. This initially broke the commit recovery of the dynamic Iceberg sink (see #14090), and was later addressed by a hot fix to aggregateWriteResultsin theDynamicCommitter.Refactor the
DynamicWriteResultAggregatorto output only one committable per triplet. Clean upDynamicCommitterto remove assumptions of multiple commit requests per table, branch, and checkpoint. This requires serializing the aggregated WriteResult using multiple temporary manifests for each unique partition spec because the Iceberg manifest writer requires a single partition spec per file. We can improve this later by changing how we serializeDataFilesandDeleteFilesfor Flink checkpoints in theDynamicSink.