Add specId to DataFile #1317
Merged
Add specId to DataFile #1317
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
rdblue
force-pushed
the
add-data-file-spec-id
branch
from
5b1c45b to
da78f03
Compare
rdblue
force-pushed
the
add-data-file-spec-id
branch
from
da78f03 to
56742bf
Compare
rdsr
reviewed
Aug 11, 2020
Contributor
rdsr
left a comment
rdsr
left a comment
There was a problem hiding this comment.
+1. Though I do see a couple core tests failing on Travis
Contributor
|
#1307 (comment) mentions that a workaround in |
Contributor
Author
|
@shardulm94, that is done in #1308. That PR includes the addition of |
rdsr
approved these changes
Aug 11, 2020
Contributor
Author
|
Thanks for reviewing @rdsr and @shardulm94! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Utilities that compare partitions need to also track the partition spec that a partition tuple belongs to because the same set of partition values can be valid for multiple specs, but identify different partitions. Many classes track the partitions of data and delete files, and the easiest way to update those utilities is to pass the spec ID along with the
DataFileinstance. Otherwise, getting the correct spec ID would require updating several public APIs to add a spec ID argument.This PR adds spec ID to
DataFileandDeleteFile, and adds it to metadata that is inherited fromManifestFile, where the spec ID of a manifest is tracked.This also cleans up unnecessary factory methods in
DataFilethat were used only in tests and were missing spec ID. Now, all data file creation uses the builder.