Fix partition sets #1308
Merged
Fix partition sets #1308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdblue
force-pushed
the
fix-partition-sets
branch
from
605c87b to
6d8a60e
Compare
Merged
rdblue
force-pushed
the
fix-partition-sets
branch
from
81b70fc to
b136822
Compare
rdblue
force-pushed
the
fix-partition-sets
branch
from
b136822 to
daacf7b
Compare
rdblue
commented
Aug 11, 2020
| } | ||
| this.hashCode = result; | ||
| } | ||
| this.hashCode = structHash.hash(struct); |
Contributor
Author
There was a problem hiding this comment.
@shardulm94, this removes the temporary work-arounds in StructLikeWrapper.
Contributor
Author
|
Thanks for reviewing, @shardulm94! |
cmathiesen
pushed a commit
to ExpediaGroup/iceberg
that referenced
this pull request
Aug 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates classes that use
StructLikeWrapperto correctly track partitions using both ID and tuple, usingDataFile.specIdfrom #1317 andPartitionSetadded by #1307.This is needed to correctly track partitions because tuples can be valid for more than one spec. For example,
(12974)is a valid partition for bothhours(ts)anddays(ts)partition specs, but does not represent the same logical partition in both.