AWS: Configure Default s3Async credentials the same as s3 #13132
+19
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e same as s3 Closes apache#13131
malhotrashivam
approved these changes
May 23, 2025
Contributor
Author
|
@SanjayMarreddi, I think should look at this since you were responsible for #12503? |
| : awsClientProperties.credentialsProvider(accessKeyId, secretAccessKey, sessionToken)); | ||
| } | ||
|
|
||
| public <T extends S3AsyncClientBuilder> void applyCredentialConfigurations( |
Member
There was a problem hiding this comment.
Are these two different hierarchies? Just wondering why we need two versions of this but I'm not familiar with AWS's code here
Contributor
Author
There was a problem hiding this comment.
Great suggestion. There is a shared hierarchy targeted for S3ClientBuilder and S3AsyncClientBuilder that is part of the AWS public API, S3BaseClientBuilder.
RussellSpitzer
approved these changes
May 29, 2025
Member
|
Merged. Thanks for the contribution @devinrsmith and the reviews @malhotrashivam ! |
devinrsmith
added a commit
to devinrsmith/iceberg
that referenced
this pull request
May 29, 2025
This was noted as something desirable during the review of apache#13132; using `S3BaseClientBuilder` removes some duplication from applyEndpointConfigurations.
devendra-nr
pushed a commit
to devendra-nr/iceberg
that referenced
this pull request
Dec 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13131