AWS: Update S3 async client configurations and docs for analytics-accelerator-s3 #12503
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SanjayMarreddi
force-pushed
the
feat/update-async-client-config
branch
from
22c9af5 to
7a323d1
Compare
fuatbasik
reviewed
Mar 12, 2025
fuatbasik
left a comment
fuatbasik
left a comment
There was a problem hiding this comment.
Thanks a lot @SanjayMarreddi. These changes LGTM.
jackye1995
reviewed
Mar 12, 2025
jackye1995
reviewed
Mar 12, 2025
jackye1995
reviewed
Mar 12, 2025
SanjayMarreddi
force-pushed
the
feat/update-async-client-config
branch
from
7a323d1 to
8b7960a
Compare
SanjayMarreddi
force-pushed
the
feat/update-async-client-config
branch
from
8b7960a to
df304c7
Compare
geruh
reviewed
Mar 12, 2025
aws/src/main/java/org/apache/iceberg/aws/s3/DefaultS3FileIOAwsClientFactory.java
Show resolved
Hide resolved
geruh
reviewed
Mar 12, 2025
geruh
approved these changes
Mar 12, 2025
Contributor
geruh
left a comment
geruh
left a comment
There was a problem hiding this comment.
LGTM, thanks for the contribution @SanjayMarreddi!
HonahX
reviewed
Mar 13, 2025
Contributor
HonahX
left a comment
HonahX
left a comment
There was a problem hiding this comment.
Thanks for the follow-up PR. Great work!
I left some comments about doc and tests. Please let me know WDYT.
aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIOProperties.java
Outdated
Show resolved
Hide resolved
HonahX
approved these changes
Mar 13, 2025
Contributor
HonahX
left a comment
HonahX
left a comment
There was a problem hiding this comment.
Thanks for adding tests! LGTM! Sorry I miss some H5 -> H4 changes in the doc. Added them in comments.
aws/src/main/java/org/apache/iceberg/aws/AwsClientProperties.java
Outdated
Show resolved
Hide resolved
SanjayMarreddi
force-pushed
the
feat/update-async-client-config
branch
from
ff544e0 to
5367b67
Compare
Contributor
|
Looks like all comments are addressed, merging, thanks @SanjayMarreddi for the work! And thanks everyone for reviewing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup PR for #12299 to:
max-concurrencyfor CRT based async clients.analytics-accelerator-s3integration.