Spark 3.4: Migrate the remaining SparkCatalogTestBase related tests and remove SparkCatalogTestBase
#13007
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@nastra Could you review this PR as well when you have time? This PR will remove the |
nastra
reviewed
May 8, 2025
| import org.junit.jupiter.api.TestTemplate; | ||
| import org.junit.jupiter.api.extension.ExtendWith; | ||
|
|
||
| @ExtendWith(ParameterizedTestExtension.class) |
Contributor
There was a problem hiding this comment.
FYI that Spark 4 now made it into the codebase, so we should eventually also sync up 3.5 <-> 4.0 tests
Contributor
Author
There was a problem hiding this comment.
Okay got it. Thanks!
Contributor
Author
|
@nastra Thank you for reviewing this PR! |
anuragmantri
added a commit
to anuragmantri/iceberg
that referenced
this pull request
Jul 25, 2025
…he#13007) (apache#1596) Co-authored-by: Tom Tanaka <[email protected]>
devendra-nr
pushed a commit
to devendra-nr/iceberg
that referenced
this pull request
Dec 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate Spark 3.4 tests based on JUnit 4 to Junit5 with AssertJ style. This is related to #7160
This PR migrates the following
SparkCatalogTestBaserelated tests to JUnit 5 with AssertJ:TestSparkTableTestStructuredStreamingRead3TestCompressionSettingsincluding the test backport from Reset Spark Conf for each test in TestCompressionSettings #11333TestRequiredDistributionAndOrderingTestSparkStagedScanPlus, additional one:
TestRuntimeFiltering