Reset Spark Conf for each test in TestCompressionSettings #11333
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
cc @szehon-ho |
RussellSpitzer
approved these changes
Oct 18, 2024
Member
RussellSpitzer
left a comment
RussellSpitzer
left a comment
There was a problem hiding this comment.
LGTM and I really appreciate that you have asserts in to make sure the config is in use!
RussellSpitzer
approved these changes
Oct 23, 2024
Contributor
Author
|
Thanks a lot @RussellSpitzer |
Member
|
Thank you @huaxingao ! It's always great to fix those hidden bad tests! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running
TestCompressionSettings#testWriteDataWithDifferentSetting(), we want to reset the Spark configuration between tests to ensure that previous settings do not influence subsequent ones. For instance, consider the following scenarios:The first configuration uses:
The second configuration uses:
Currently, the configuration does not reset, so the second setting unexpectedly retains the
COMPRESSION_LEVELfrom the first setting, resulting inCOMPRESSION_CODEC, "gzip", COMPRESSION_LEVEL, "1". This can lead to unexpected behavior.