Core: Update metadata location without updating lastUpdatedMillis #11151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
3 tasks
nastra
force-pushed
the
fix-loadtable-resp-metadata
branch
from
7ee6c13
to
799889b
Compare
nastra
commented
Sep 17, 2024
rdblue
reviewed
Sep 17, 2024
rdblue
reviewed
Sep 17, 2024
nastra
force-pushed
the
fix-loadtable-resp-metadata
branch
2 times, most recently
from
8845d10
to
72211c0
Compare
Using `TableMetadata.buildFrom(metadata).withMetadataLocation(metadataLocation).build()` would do the following things: - update `lastUpdatedMillis` - write a new `metadata-log` entry However, in `LoadTableResponse` the goal is to only update the metadata location without updating the two mentioned things above. updates
nastra
force-pushed
the
fix-loadtable-resp-metadata
branch
from
72211c0
to
08d7d85
Compare
rdblue
approved these changes
Sep 17, 2024
|
Thanks for the update! Looks good now. Please merge when tests are passing. |
dramaticlly
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
TableMetadata.buildFrom(metadata).withMetadataLocation(metadataLocation).build()would do the following things:lastUpdatedMillismetadata-logentryHowever, in
LoadTableResponsethe goal is to only update the metadata location without updating the two mentioned things above.