Core: Add explicit JSON parser for LoadTableResponse #11148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nastra
changed the title
nastra
force-pushed
the
loadtableresponse-parser
branch
from
4378597
to
c92778d
Compare
nastra
force-pushed
the
loadtableresponse-parser
branch
from
c92778d
to
e742224
Compare
nastra
force-pushed
the
loadtableresponse-parser
branch
from
e742224
to
25de5c1
Compare
nastra
commented
Sep 18, 2024
| @@ -61,7 +62,12 @@ public String metadataLocation() { | |||
| } | |||
|
|
|||
| public TableMetadata tableMetadata() { | |||
| return TableMetadata.buildFrom(metadata).withMetadataLocation(metadataLocation).build(); | |||
| if (null == metadataWithLocation) { | |||
There was a problem hiding this comment.
we were rebuilding the metadata on every call to tableMetadata() which was required when java reflection was used for JSON deserialiazion. However, now this isn't needed anymore, so we can compute the metadata with the location only once
amogh-jahagirdar
approved these changes
Sep 19, 2024
|
thanks @amogh-jahagirdar for the review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces an explicit JSON parser for
LoadTableResponseas a preparation step for standardizing credentials as proposed in #10722.Currently,
LoadTableResponseis relying on reflection to properly do JSON <-->LoadTableResponse.Having an explicit JSON parser has the advantage that the underlying
credentialscan be parsed in a way that gives us more flexiblity and allows to be fully forward/backward compatible when new credentials are being added.This currently depends on #11151