Core: Add a util to compute partition stats #11146
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajantha-bhat
commented
Sep 16, 2024
ajantha-bhat
force-pushed
the
compute_stats_no_lock
branch
from
1fb368c to
d3982f5
Compare
aokolnychyi
reviewed
Sep 21, 2024
Contributor
aokolnychyi
left a comment
aokolnychyi
left a comment
There was a problem hiding this comment.
I like the new approach of collecting stats per manifest and then merging them. Left a few suggestions. Nice work, @ajantha-bhat!
core/src/jmh/java/org/apache/iceberg/PartitionStatsUtilBenchmark.java
Outdated
Show resolved
Hide resolved
ajantha-bhat
force-pushed
the
compute_stats_no_lock
branch
2 times, most recently
from
5c2cf66 to
9ee176b
Compare
aokolnychyi
reviewed
Sep 24, 2024
core/src/jmh/java/org/apache/iceberg/PartitionStatsUtilBenchmark.java
Outdated
Show resolved
Hide resolved
aokolnychyi
reviewed
Sep 24, 2024
core/src/jmh/java/org/apache/iceberg/PartitionStatsUtilBenchmark.java
Outdated
Show resolved
Hide resolved
core/src/jmh/java/org/apache/iceberg/PartitionStatsUtilBenchmark.java
Outdated
Show resolved
Hide resolved
ajantha-bhat
force-pushed
the
compute_stats_no_lock
branch
from
6af77f9 to
561ffce
Compare
ajantha-bhat
force-pushed
the
compute_stats_no_lock
branch
from
561ffce to
bf1097d
Compare
aokolnychyi
approved these changes
Sep 26, 2024
Contributor
aokolnychyi
left a comment
aokolnychyi
left a comment
There was a problem hiding this comment.
LGTM, final minor/cosmetic comments.
Member
Author
|
@aokolnychyi: Thanks for the review and guidance. |
Contributor
|
Thanks for the hard work, @ajantha-bhat! Great to have this in. |
13 tasks
zachdisc
pushed a commit
to zachdisc/iceberg
that referenced
this pull request
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced two API's to compute and sort partition stats as per spec.
Iterable<PartitionStats> partitionStats = PartitionStatsUtil.computeStats(table, table.currentSnapshot());PartitionStatsUtil.sortStats(partitionStats, Partitioning.partitionType(table));These will be used by engines integrated with writer to compute and write the partition stats.