Skip to content

Core: Fix setting hasNewDataFile flag in MergingSnapshotProducer #11088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aokolnychyi merged 1 commit into from
Sep 7, 2024
Merged

Core: Fix setting hasNewDataFile flag in MergingSnapshotProducer #11088

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/src/main/java/org/apache/iceberg/MergingSnapshotProducer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -984,11 +984,11 @@ private List<ManifestFile> newDataFilesAsManifests() {
writer.close();
}
this.cachedNewDataManifests.addAll(writer.toManifestFiles());
this.hasNewDataFiles = false;
Copy link
Contributor Author

@aokolnychyi aokolnychyi Sep 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it caused issues but it would be more correct to set hasNewDataFiles to false after processing all new data files, similarly to what we do for delete files. Otherwise, it is confusing.

Copy link
Contributor

@amogh-jahagirdar amogh-jahagirdar Sep 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah agreed, this change is easier to read. Also agree that setting it to false prematurely shouldn't have caused issues, looking at how hasNewDataFiles is used

} catch (IOException e) {
throw new RuntimeIOException(e, "Failed to close manifest writer");
}
});
this.hasNewDataFiles = false;
}

return cachedNewDataManifests;
Expand Down