Core: Fix setting hasNewDataFile flag in MergingSnapshotProducer #11088
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aokolnychyi
commented
Sep 6, 2024
| writer.close(); | ||
| } | ||
| this.cachedNewDataManifests.addAll(writer.toManifestFiles()); | ||
| this.hasNewDataFiles = false; |
Contributor
Author
There was a problem hiding this comment.
I don't think it caused issues but it would be more correct to set hasNewDataFiles to false after processing all new data files, similarly to what we do for delete files. Otherwise, it is confusing.
Contributor
There was a problem hiding this comment.
Yeah agreed, this change is easier to read. Also agree that setting it to false prematurely shouldn't have caused issues, looking at how hasNewDataFiles is used
amogh-jahagirdar
approved these changes
Sep 6, 2024
| writer.close(); | ||
| } | ||
| this.cachedNewDataManifests.addAll(writer.toManifestFiles()); | ||
| this.hasNewDataFiles = false; |
Contributor
There was a problem hiding this comment.
Yeah agreed, this change is easier to read. Also agree that setting it to false prematurely shouldn't have caused issues, looking at how hasNewDataFiles is used
Contributor
Author
|
Thanks, @amogh-jahagirdar! |
zachdisc
pushed a commit
to zachdisc/iceberg
that referenced
this pull request
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the support for adding data files that belong to multiple specs in #9860, we have to fix resetting
hasNewDataFile.