Docs: Fix internal links in 1.5.x releases#10411
Conversation
|
@manuzhang have you tried running this locally? |
|
@bitsondatadev After this PR we need to fix this in the docs branch, right? |
|
@Fokko This PR is open against docs branch. |
| | cache-enabled | true | Whether to cache catalog entries | | ||
| | cache.expiration-interval-ms | 30000 | How long catalog entries are locally cached, in milliseconds; 0 disables caching, negative values disable expiration | | ||
| | metrics-reporter-impl | org.apache.iceberg.metrics.LoggingMetricsReporter | Custom `MetricsReporter` implementation to use in a catalog. See the [Metrics reporting](../metrics-reporting.md) section for additional details | | ||
| | metrics-reporter-impl | org.apache.iceberg.metrics.LoggingMetricsReporter | Custom `MetricsReporter` implementation to use in a catalog. See the [Metrics reporting](metrics-reporting.md) section for additional details | |
There was a problem hiding this comment.
I'm surprised that this is an issue in the 1.5.2 docs given that ##9965 fixed this before 1.5.2 went out. @amogh-jahagirdar I'm guessing docs-wise for #10282 you were probably just using whatever existed for the 1.5.1 docs? At that time we most likely just haven't had backports for the link fixes
There was a problem hiding this comment.
At that time we most likely just haven't had backports for the link fixes
Exactly. #9965 got merged (March 23, 2024) after the 1.5.0 release (March 11, 2024), so those fixes are not on the 1.5.x branch.
There was a problem hiding this comment.
Just so it's clear I still have a link fix en route, I just need to recall the decision we made regarding absolute vs relative links.
|
@manuzhang did you run this locally and do the links across versions work now correctly? |
Fokko
left a comment
Fokko
left a comment
There was a problem hiding this comment.
Looks good! Thanks for taking care of this @manuzhang
We can check afterwards if we missed anything by running the link checker #10404 (comment)
|
thanks for taking care of this @manuzhang |
4 participants
This fixes #10409, #10249
cc @nastra, @Fokko, @bitsondatadev