Merged
Conversation
manuzhang
approved these changes
May 30, 2024
Member
|
@Fokko we need to remove the config file as well. |
Contributor
Author
|
@manuzhang I was thinking of leaving in the link checker, but just removing it from the CI for now. You could still run it locally: https://github.com/apache/iceberg/tree/main/site#validate-links WDYT? |
manuzhang
approved these changes
Jun 1, 2024
pvary
approved these changes
Jun 1, 2024
Member
|
@Fokko I'm good with leaving in the link checker, but we need to update the README which refers to another python linkchecker. |
Contributor
Author
|
@manuzhang Good catch, that one was originally added by @bitsondatadev. Let's keep that one in, it works pretty well: Current broken links: It only checks internal links by default. |
Running the links checker from the CI turns out the be very flaky: apache#10397 Let's remove it for now: cc @manuzhang @pvary
08374c1 to
c992d7b
Compare
Member
|
@Fokko Do you plan to merge this? |
Contributor
Author
|
@manuzhang Yes, I was out the last few days, thanks for pinging me 👍 |
jasonf20
pushed a commit
to jasonf20/iceberg
that referenced
this pull request
Aug 4, 2024
Running the links checker from the CI turns out the be very flaky: apache#10397 Let's remove it for now: cc @manuzhang @pvary
sasankpagolu
pushed a commit
to sasankpagolu/iceberg
that referenced
this pull request
Oct 27, 2024
Running the links checker from the CI turns out the be very flaky: apache#10397 Let's remove it for now: cc @manuzhang @pvary
zachdisc
pushed a commit
to zachdisc/iceberg
that referenced
this pull request
Dec 23, 2024
Running the links checker from the CI turns out the be very flaky: apache#10397 Let's remove it for now: cc @manuzhang @pvary
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I introduced this Github Actions workflow a while ago, but it turned out to be a mistake. Running the links checker from the CI turns out the be very flaky: #10397 Let's remove it for now.
cc @manuzhang @pvary