Skip to content
This repository was archived by the owner on Feb 6, 2024. It is now read-only.

Conversation

@tmater
Copy link
Contributor

@tmater tmater commented Jun 17, 2022

No description provided.

@pvary
Copy link
Contributor

pvary commented Jun 21, 2022

@samredai: Any comment on this?
Can I merge this PR?

Thanks,
Peter

@samredai
Copy link
Contributor

I'm ok with adding this now and moving it later, but having individual items in the top navbar for each engine will go away soon (see PR #75) in favor of just a "Quickstart" and "Overview" nav element.

There will be a separate "Integrations" section in the docs left-nav where all integrations will be listed/described which is where this should exist. Following up with an Impala QuickStart that uses docker would also be helpful.

@pvary
Copy link
Contributor

pvary commented Jun 21, 2022

@samredai: Any timeline for #75? There are some Hive (#4915) and CDP (#4536) PRs waiting for it for a while now. If we merge #75 soon, I am all for waiting for the final version, but it would be good if the users could see the Hive/Impala docs soon.

@samredai
Copy link
Contributor

I'm finishing up #91 now which should be ready to review today. Once that's merged then #75 just needs to be rebased and merged. I'm hoping to wrap this all up this week.

@pvary
Copy link
Contributor

pvary commented Jun 21, 2022

I'm finishing up #91 now which should be ready to review today. Once that's merged then #75 just needs to be rebased and merged. I'm hoping to wrap this all up this week.

Thanks @samredai! Then I think we should wait a little bit more.

@pvary
Copy link
Contributor

pvary commented Jun 28, 2022

Hi @samredai!
Any news? We would like to make the Apache Impala / Apache Hive docs available soon. Maybe we just merge them now, and do the rebase with the other rebase work?
Thanks,
Peter

@samredai
Copy link
Contributor

Hey @pvary, just putting the finishing touches on the other PRs. I'm ok with this getting merged now and I can make any required format changes later if needed! cc: @rdblue

@pvary pvary merged commit 90bcde8 into apache:main Jun 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants