Skip to content

HUDI-290 Normalize test class name of all test classes #943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yanghua wants to merge 1 commit into from
Closed

HUDI-290 Normalize test class name of all test classes #943

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...he/hudi/config/HoodieWriteConfigTest.java → ...he/hudi/config/TestHoodieWriteConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
import org.apache.hudi.config.HoodieWriteConfig.Builder;
import org.junit.Test;

public class HoodieWriteConfigTest {
public class TestHoodieWriteConfig {

@Test
public void testPropertyLoading() throws IOException {
Expand Down
2 changes: 1 addition & 1 deletion ...mmon/table/HoodieTableMetaClientTest.java → ...mmon/table/TestHoodieTableMetaClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
import org.junit.Before;
import org.junit.Test;

public class HoodieTableMetaClientTest extends HoodieCommonTestHarness {
public class TestHoodieTableMetaClient extends HoodieCommonTestHarness {

@Before
public void init() throws IOException {
Expand Down
4 changes: 2 additions & 2 deletions ...common/table/log/HoodieLogFormatTest.java → ...common/table/log/TestHoodieLogFormat.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,15 +77,15 @@

@SuppressWarnings("Duplicates")
@RunWith(Parameterized.class)
public class HoodieLogFormatTest extends HoodieCommonTestHarness {
public class TestHoodieLogFormat extends HoodieCommonTestHarness {

private static String BASE_OUTPUT_PATH = "/tmp/";
private FileSystem fs;
private Path partitionPath;
private int bufferSize = 4096;
private Boolean readBlocksLazily = true;

public HoodieLogFormatTest(Boolean readBlocksLazily) {
public TestHoodieLogFormat(Boolean readBlocksLazily) {
this.readBlocksLazily = readBlocksLazily;
}

Expand Down
2 changes: 1 addition & 1 deletion ...log/HoodieLogFormatAppendFailureTest.java → ...log/TestHoodieLogFormatAppendFailure.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@
* {@link MiniClusterUtil} to reproduce append() issue : https://issues.apache.org/jira/browse/HDFS-6325 Reference :
* https://issues.apache.org/jira/secure/attachment/12645053/HDFS-6325.patch
*/
public class HoodieLogFormatAppendFailureTest {
public class TestHoodieLogFormatAppendFailure {

private static File baseDir;
private static MiniDFSCluster cluster;
Expand Down
2 changes: 1 addition & 1 deletion ...able/string/HoodieActiveTimelineTest.java → ...able/string/TestHoodieActiveTimeline.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
import org.junit.Test;
import org.junit.rules.ExpectedException;

public class HoodieActiveTimelineTest extends HoodieCommonTestHarness {
public class TestHoodieActiveTimeline extends HoodieCommonTestHarness {

private HoodieActiveTimeline timeline;
@Rule
Expand Down
4 changes: 2 additions & 2 deletions ...e/view/HoodieTableFileSystemViewTest.java → ...e/view/TestHoodieTableFileSystemView.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,9 +64,9 @@
import org.junit.Test;

@SuppressWarnings("ResultOfMethodCallIgnored")
public class HoodieTableFileSystemViewTest extends HoodieCommonTestHarness {
public class TestHoodieTableFileSystemView extends HoodieCommonTestHarness {

private static final transient Logger log = LogManager.getLogger(HoodieTableFileSystemViewTest.class);
private static final transient Logger log = LogManager.getLogger(TestHoodieTableFileSystemView.class);

private static String TEST_WRITE_TOKEN = "1-0-1";

Expand Down
4 changes: 2 additions & 2 deletions ...table/view/IncrementalFSViewSyncTest.java → ...table/view/TestIncrementalFSViewSync.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,9 +69,9 @@
import org.junit.Before;
import org.junit.Test;

public class IncrementalFSViewSyncTest extends HoodieCommonTestHarness {
public class TestIncrementalFSViewSync extends HoodieCommonTestHarness {

private static final transient Logger log = LogManager.getLogger(IncrementalFSViewSyncTest.class);
private static final transient Logger log = LogManager.getLogger(TestIncrementalFSViewSync.class);

private static String TEST_WRITE_TOKEN = "1-0-1";

Expand Down
2 changes: 1 addition & 1 deletion ...ocksDBBasedIncrementalFSViewSyncTest.java → ...estRocksDBBasedIncrementalFSViewSync.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
import org.apache.hudi.common.table.HoodieTimeline;
import org.apache.hudi.common.table.SyncableFileSystemView;

public class RocksDBBasedIncrementalFSViewSyncTest extends IncrementalFSViewSyncTest {
public class TestRocksDBBasedIncrementalFSViewSync extends TestIncrementalFSViewSync {

@Override
protected SyncableFileSystemView getFileSystemView(HoodieTableMetaClient metaClient, HoodieTimeline timeline)
Expand Down
2 changes: 1 addition & 1 deletion .../view/RocksDbBasedFileSystemViewTest.java → .../view/TestRocksDbBasedFileSystemView.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
import org.apache.hudi.common.table.HoodieTimeline;
import org.apache.hudi.common.table.SyncableFileSystemView;

public class RocksDbBasedFileSystemViewTest extends HoodieTableFileSystemViewTest {
public class TestRocksDbBasedFileSystemView extends TestHoodieTableFileSystemView {

protected SyncableFileSystemView getFileSystemView(HoodieTimeline timeline) throws IOException {
return new RocksDbBasedFileSystemView(metaClient, timeline,
Expand Down
2 changes: 1 addition & 1 deletion .../SpillableMapBasedFileSystemViewTest.java → .../TestSpillableMapBasedFileSystemView.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
import org.apache.hudi.common.table.HoodieTimeline;
import org.apache.hudi.common.table.SyncableFileSystemView;

public class SpillableMapBasedFileSystemViewTest extends HoodieTableFileSystemViewTest {
public class TestSpillableMapBasedFileSystemView extends TestHoodieTableFileSystemView {

protected SyncableFileSystemView getFileSystemView(HoodieTimeline timeline) {
return new SpillableMapBasedFileSystemView(metaClient, timeline, FileSystemViewStorageConfig.newBuilder()
Expand Down
2 changes: 1 addition & 1 deletion ...bleMapBasedIncrementalFSViewSyncTest.java → ...illableMapBasedIncrementalFSViewSync.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
import org.apache.hudi.common.table.HoodieTimeline;
import org.apache.hudi.common.table.SyncableFileSystemView;

public class SpillableMapBasedIncrementalFSViewSyncTest extends IncrementalFSViewSyncTest {
public class TestSpillableMapBasedIncrementalFSViewSync extends TestIncrementalFSViewSync {

@Override
protected SyncableFileSystemView getFileSystemView(HoodieTableMetaClient metaClient, HoodieTimeline timeline) {
Expand Down
2 changes: 1 addition & 1 deletion ...rg/apache/hudi/hadoop/AnnotationTest.java → ...rg/apache/hudi/hadoop/TestAnnotation.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
import java.lang.annotation.Annotation;
import org.junit.Test;

public class AnnotationTest {
public class TestAnnotation {

@Test
public void testAnnotation() {
Expand Down
2 changes: 1 addition & 1 deletion ...he/hudi/hadoop/HoodieInputFormatTest.java → ...he/hudi/hadoop/TestHoodieInputFormat.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
import org.junit.Test;
import org.junit.rules.TemporaryFolder;

public class HoodieInputFormatTest {
public class TestHoodieInputFormat {

private HoodieParquetInputFormat inputFormat;
private JobConf jobConf;
Expand Down
2 changes: 1 addition & 1 deletion ...ltime/HoodieRealtimeRecordReaderTest.java → ...ltime/TestHoodieRealtimeRecordReader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@
import org.junit.Test;
import org.junit.rules.TemporaryFolder;

public class HoodieRealtimeRecordReaderTest {
public class TestHoodieRealtimeRecordReader {

private JobConf jobConf;
private FileSystem fs;
Expand Down
4 changes: 2 additions & 2 deletions ...rg/apache/hudi/hive/HiveSyncToolTest.java → ...rg/apache/hudi/hive/TestHiveSyncTool.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,12 +46,12 @@

@SuppressWarnings("ConstantConditions")
@RunWith(Parameterized.class)
public class HiveSyncToolTest {
public class TestHiveSyncTool {

// Test sync tool using both jdbc and metastore client
private boolean useJdbc;

public HiveSyncToolTest(Boolean useJdbc) {
public TestHiveSyncTool(Boolean useJdbc) {
this.useJdbc = useJdbc;
}

Expand Down
2 changes: 1 addition & 1 deletion hudi-hive/src/test/java/org/apache/hudi/hive/TestUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ public static void setUp() throws IOException, InterruptedException, URISyntaxEx
hiveSyncConfig.hivePass = "";
hiveSyncConfig.databaseName = "testdb";
hiveSyncConfig.tableName = "test1";
hiveSyncConfig.basePath = "/tmp/hdfs/HiveSyncToolTest/";
hiveSyncConfig.basePath = "/tmp/hdfs/TestHiveSyncTool/";
Copy link
Contributor Author

@yanghua yanghua Oct 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except for renaming, it is the only change. It should not affect the failed test case. WDYT? @vinothchandar

Copy link
Member

@vinothchandar vinothchandar Oct 10, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No this should not affect anything.. Can you reproduce the error locally? the VM timeout happened in the past from leaking writeClient (i.e tests not calling writeClient.close()). But we fixed it and its all been stable since june. Again does not seem related to this,

Copy link
Contributor Author

@yanghua yanghua Oct 10, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran this test several times. It can be passed (although the test took much time).

hiveSyncConfig.assumeDatePartitioning = true;
hiveSyncConfig.usePreApacheInputFormat = false;
hiveSyncConfig.partitionFields = Lists.newArrayList("datestr");
Expand Down
2 changes: 1 addition & 1 deletion ...spark/src/test/scala/DataSourceTest.scala → ...spark/src/test/scala/TestDataSource.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ import scala.concurrent.{Await, Future}
/**
* Basic tests on the spark datasource
*/
class DataSourceTest extends AssertionsForJUnit {
class TestDataSource extends AssertionsForJUnit {

var spark: SparkSession = null
var dataGen: HoodieTestDataGenerator = null
Expand Down
2 changes: 1 addition & 1 deletion ...c/test/scala/DataSourceDefaultsTest.scala → ...c/test/scala/TestDataSourceDefaults.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ import org.scalatest.junit.AssertionsForJUnit
/**
* Tests on the default key generator, payload classes.
*/
class DataSourceDefaultsTest extends AssertionsForJUnit {
class TestDataSourceDefaults extends AssertionsForJUnit {

val schema = SchemaTestUtil.getComplexEvolvedSchema
var baseRecord: GenericRecord = null
Expand Down
8 changes: 4 additions & 4 deletions .../RemoteHoodieTableFileSystemViewTest.java → .../TestRemoteHoodieTableFileSystemView.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,18 +24,18 @@
import org.apache.hudi.common.table.view.FileSystemViewManager;
import org.apache.hudi.common.table.view.FileSystemViewStorageConfig;
import org.apache.hudi.common.table.view.FileSystemViewStorageType;
import org.apache.hudi.common.table.view.HoodieTableFileSystemViewTest;
import org.apache.hudi.common.table.view.RemoteHoodieTableFileSystemView;
import org.apache.hudi.common.table.view.TestHoodieTableFileSystemView;
import org.apache.hudi.timeline.service.TimelineService;
import org.apache.log4j.LogManager;
import org.apache.log4j.Logger;

/**
* Bring up a remote Timeline Server and run all test-cases of HoodieTableFileSystemViewTest against it
* Bring up a remote Timeline Server and run all test-cases of TestHoodieTableFileSystemView against it
*/
public class RemoteHoodieTableFileSystemViewTest extends HoodieTableFileSystemViewTest {
public class TestRemoteHoodieTableFileSystemView extends TestHoodieTableFileSystemView {

private static Logger log = LogManager.getLogger(RemoteHoodieTableFileSystemViewTest.class);
private static Logger log = LogManager.getLogger(TestRemoteHoodieTableFileSystemView.class);

private TimelineService server;
private RemoteHoodieTableFileSystemView view;
Expand Down
2 changes: 1 addition & 1 deletion ...utilities/SchedulerConfGeneratorTest.java → ...utilities/TestSchedulerConfGenerator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
import org.apache.hudi.utilities.deltastreamer.SchedulerConfGenerator;
import org.junit.Test;

public class SchedulerConfGeneratorTest {
public class TestSchedulerConfGenerator {

@Test
public void testGenerateSparkSchedulingConf() throws Exception {
Expand Down