Skip to content

Conversation

@yanghua
Copy link
Contributor

@yanghua yanghua commented Oct 8, 2019

@leesf
Copy link
Contributor

leesf commented Oct 8, 2019

The changes LGTM, but there has an exception(Expected feature release number in range of 9 to 14, but got: 8) in CI(https://api.travis-ci.org/v3/job/595080762/log.txt) which seems to be the problem of CI and irrelative to the changes.
ping @vinothchandar @bvaradar

@yanghua
Copy link
Contributor Author

yanghua commented Oct 8, 2019

@leesf Thanks for your review. Yes, Currently, the Travis may not be normal.

@vinothchandar
Copy link
Member

I rekicked the build (if you login to travis, it lets you restart the build) and it failed again.. CI has been fairly stable actually https://travis-ci.org/apache/incubator-hudi/branches & also you can see travisci channel on slack.

I see that after we merged the sealing/unsealing pr, there is the same failure on master (cant understand how that PR would affect this either)..

@vinothchandar
Copy link
Member

My theory based on https://travis-ci.community/t/install-of-oracle-jdk8-is-failing/4365/2 . The pool for the our jobs might have changed (or machines upgraded).. So we are hitting oracle jdk issues with licensing

@leesf
Copy link
Contributor

leesf commented Oct 8, 2019

@vinothchandar
Copy link
Member

lets see how this one goes. #944

@vinothchandar
Copy link
Member

could you rebase against master and try pushing again

@yanghua yanghua force-pushed the HUDI-290 branch 3 times, most recently from 6b967de to 56ac92b Compare October 9, 2019 10:54
@yanghua
Copy link
Contributor Author

yanghua commented Oct 9, 2019

I found this test:

  TestHoodieDeltaStreamer.testUpsertsMORContinuousMode:359->testUpsertsContinuousMode:382 » Timeout

failed twice.

However, this PR only renamed some test class names. Do not know the reason for the timeout.

@vinothchandar Do you think the renaming behavior would affect the test stable?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except for renaming, it is the only change. It should not affect the failed test case. WDYT? @vinothchandar

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No this should not affect anything.. Can you reproduce the error locally? the VM timeout happened in the past from leaking writeClient (i.e tests not calling writeClient.close()). But we fixed it and its all been stable since june. Again does not seem related to this,

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran this test several times. It can be passed (although the test took much time).

@vinothchandar
Copy link
Member

Rekicked the job.. lets see

@yanghua
Copy link
Contributor Author

yanghua commented Oct 10, 2019

Let me trigger Travis again.

@vinothchandar
Copy link
Member

https://travis-ci.org/apache/incubator-hudi/builds has been pretty stable as you can see.. Log is full of the following type of errors talking to the Mini DFS cluster

org.apache.hudi.exception.HoodieIOException: Could not check if dataset hdfs://localhost:40221/user/travis/continuous_mor is valid dataset
	at org.apache.hudi.exception.DatasetNotFoundException.checkValidDataset(DatasetNotFoundException.java:53)
	at org.apache.hudi.common.table.HoodieTableMetaClient.<init>(HoodieTableMetaClient.java:104)
	at org.apache.hudi.common.table.HoodieTableMetaClient.<init>(HoodieTableMetaClient.java:90)
	at org.apache.hudi.common.table.HoodieTableMetaClient.<init>(HoodieTableMetaClient.java:85)
	at org.apache.hudi.utilities.TestHoodieDeltaStreamer$TestHelpers.assertAtleastNDeltaCommits(TestHoodieDeltaStreamer.java:243)
	at org.apache.hudi.utilities.TestHoodieDeltaStreamer.lambda$testUpsertsContinuousMode$1(TestHoodieDeltaStreamer.java:384)
	at org.apache.hudi.utilities.TestHoodieDeltaStreamer$TestHelpers.lambda$waitTillCondition$0(TestHoodieDeltaStreamer.java:268)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
	at java.lang.Thread.run(Thread.java:748)
Caused by: java.net.ConnectException: Call From localhost/127.0.0.1 to localhost:40221 failed on connection exception: java.net.ConnectException: Connection refused; For more details see:  http://wiki.apache.org/hadoop/ConnectionRefused
	at sun.reflect.GeneratedConstructorAccessor157.newInstance(Unknown Source)
	at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
	at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
	at org.apache.hadoop.net.NetUtils.wrapWithMessage(NetUtils.java:792)
	at org.apache.hadoop.net.NetUtils.wrapException(NetUtils.java:732)
	at org.apache.hadoop.ipc.Client.call(Client.java:1479)
	at org.apache.hadoop.ipc.Client.call(Client.java:1412)

So this passes locally for you and just fails on travis? right?

@yanghua
Copy link
Contributor Author

yanghua commented Oct 10, 2019

@vinothchandar Yes, it always OK in my local. However, I do not know why it failed so many times in this PR. I do not see this phenomena before.

@vinothchandar
Copy link
Member

I can try grabbing this branch, open PR and see etc? I am out of ideas as well. Seems like some networking issue

@yanghua
Copy link
Contributor Author

yanghua commented Oct 10, 2019

@vinothchandar Yes, it would be very apprecite if you can give a help.

@vinothchandar
Copy link
Member

Will close this in favor of the other one.. Cannot repro this locally.. still digging

vamsikarnika pushed a commit to vamsikarnika/hudi that referenced this pull request Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants