-
Notifications
You must be signed in to change notification settings - Fork 2.5k
HUDI-290 Normalize test class name of all test classes #943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The changes LGTM, but there has an exception(Expected feature release number in range of 9 to 14, but got: 8) in CI(https://api.travis-ci.org/v3/job/595080762/log.txt) which seems to be the problem of CI and irrelative to the changes. |
|
@leesf Thanks for your review. Yes, Currently, the Travis may not be normal. |
|
I rekicked the build (if you login to travis, it lets you restart the build) and it failed again.. CI has been fairly stable actually https://travis-ci.org/apache/incubator-hudi/branches & also you can see travisci channel on slack. I see that after we merged the sealing/unsealing pr, there is the same failure on master (cant understand how that PR would affect this either).. |
|
My theory based on https://travis-ci.community/t/install-of-oracle-jdk8-is-failing/4365/2 . The pool for the our jobs might have changed (or machines upgraded).. So we are hitting oracle jdk issues with licensing |
|
lets see how this one goes. #944 |
|
could you rebase against master and try pushing again |
6b967de to
56ac92b
Compare
|
I found this test: failed twice. However, this PR only renamed some test class names. Do not know the reason for the timeout. @vinothchandar Do you think the renaming behavior would affect the test stable? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Except for renaming, it is the only change. It should not affect the failed test case. WDYT? @vinothchandar
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No this should not affect anything.. Can you reproduce the error locally? the VM timeout happened in the past from leaking writeClient (i.e tests not calling writeClient.close()). But we fixed it and its all been stable since june. Again does not seem related to this,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran this test several times. It can be passed (although the test took much time).
|
Rekicked the job.. lets see |
|
Let me trigger Travis again. |
|
https://travis-ci.org/apache/incubator-hudi/builds has been pretty stable as you can see.. Log is full of the following type of errors talking to the Mini DFS cluster So this passes locally for you and just fails on travis? right? |
|
@vinothchandar Yes, it always OK in my local. However, I do not know why it failed so many times in this PR. I do not see this phenomena before. |
|
I can try grabbing this branch, open PR and see etc? I am out of ideas as well. Seems like some networking issue |
|
@vinothchandar Yes, it would be very apprecite if you can give a help. |
|
Will close this in favor of the other one.. Cannot repro this locally.. still digging |
jira: https://issues.apache.org/jira/browse/HUDI-290