[HUDI-6174] Fixing flaky tests in HoodieDeltastreamer #8646
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yihua
approved these changes
May 5, 2023
| // Step 5 : FirstReplaceHoodieInstant should not be retained. | ||
| long count = meta.reloadActiveTimeline().getCompletedReplaceTimeline().getInstantsAsStream().filter(instant -> firstReplaceHoodieInstant.get().equals(instant)).count(); | ||
| assertEquals(1, count); | ||
| assertEquals(0, count); |
Contributor
There was a problem hiding this comment.
Do we want construct a test where the replacecommit should be retained?
Contributor
There was a problem hiding this comment.
@nsivabalan I'll land this PR to unblock CI. Let's follow up on this.
4 tasks
nsivabalan
force-pushed
the
fixFlakyTestMay5
branch
from
227ea1a to
782d73b
Compare
yihua
pushed a commit
to yihua/hudi
that referenced
this pull request
May 15, 2023
yihua
pushed a commit
to yihua/hudi
that referenced
this pull request
May 15, 2023
yihua
pushed a commit
to yihua/hudi
that referenced
this pull request
May 17, 2023
wombatu-kun
reviewed
Jul 18, 2024
| // collect active commits for table | ||
| val commits = spark.sql(s"""call show_commits(table => '$tableName', limit => 10)""").collect() | ||
| assertResult(5) { | ||
| assertResult(4) { |
Contributor
There was a problem hiding this comment.
@nsivabalan @yihua
Can somebody explain it? What is the root cause of the changes in the results here? Why when we "insert data to table, will generate 5 active commits and 2 archived commits" get only 4 commits here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Logs
Fixing flaky cleaner and replace commit tests in TestHoodieDeltastreamer
Impact
Fixing flaky cleaner and replace commit tests in TestHoodieDeltastreamer
Risk level (write none, low medium or high below)
low.
Documentation Update
Describe any necessary documentation update if there is any new feature, config, or user-facing change
ticket number here and follow the instruction to make
changes to the website.
Contributor's checklist