[HUDI-6168] Add ability to parse partition value into row for S3 and GCS sources #8629
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the-other-tim-brown
changed the title
codope
reviewed
May 4, 2023
...ties/src/main/java/org/apache/hudi/utilities/sources/helpers/CloudObjectsSelectorCommon.java
Show resolved
Hide resolved
codope
approved these changes
May 4, 2023
Member
codope
left a comment
codope
left a comment
There was a problem hiding this comment.
Can land once the CI is green.
Contributor
|
@hudi-bot run azure |
Collaborator
Contributor
|
going ahead w/ landing. the test failure is a known flaky one. #8646 |
yihua
reviewed
May 13, 2023
Comment on lines
+106
to
+109
| /** | ||
| * A comma delimited list of path-based partition fields in the source file structure | ||
| */ | ||
| public static final String PATH_BASED_PARTITION_FIELDS = "hoodie.deltastreamer.source.cloud.data.partition.fields.from.path"; |
Contributor
There was a problem hiding this comment.
We should add new configs in CloudSourceConfig.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Logs
Adds the ability to parse the partition path in a source if specified and add the value into the row.
Add unit tests for the class
Impact
Adds new feature to add value that is present in the path
Risk level (write none, low medium or high below)
none
Documentation Update
Describe any necessary documentation update if there is any new feature, config, or user-facing change
ticket number here and follow the instruction to make
changes to the website.
Contributor's checklist