Skip to content

[MINOR] Fixed hadoop configuration not being applied by FileIndex #8595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danny0405 merged 3 commits into from
May 4, 2023
Merged

[MINOR] Fixed hadoop configuration not being applied by FileIndex #8595

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
38e644e
[MINOR] Fixed hadoop configuration not being applied by FileIndex
Paddy0523 Apr 28, 2023
21e3090
[MINOR] keep the hadoop conf as member
Paddy0523 May 4, 2023
ae38bcb
[MINOR]Generating the HoodieFlinkEngineContext on the fly
Paddy0523 May 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/source/FileIndex.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ public class FileIndex {
private final RowType rowType;
private final boolean tableExists;
private final HoodieMetadataConfig metadataConfig;
private final org.apache.hadoop.conf.Configuration hadoopConf;
private final PartitionPruners.PartitionPruner partitionPruner; // for partition pruning
private final DataPruner dataPruner; // for data skipping
private final int dataBucket; // for bucket pruning
Expand All @@ -74,7 +75,8 @@ public class FileIndex {
private FileIndex(Path path, Configuration conf, RowType rowType, DataPruner dataPruner, PartitionPruners.PartitionPruner partitionPruner, int dataBucket) {
this.path = path;
this.rowType = rowType;
this.tableExists = StreamerUtil.tableExists(path.toString(), HadoopConfigurations.getHadoopConf(conf));
this.hadoopConf = HadoopConfigurations.getHadoopConf(conf);
this.tableExists = StreamerUtil.tableExists(path.toString(), hadoopConf);
this.metadataConfig = metadataConfig(conf);
this.dataPruner = isDataSkippingFeasible(conf.getBoolean(FlinkOptions.READ_DATA_SKIPPING_ENABLED)) ? dataPruner : null;
this.partitionPruner = partitionPruner;
Expand Down Expand Up @@ -145,7 +147,8 @@ public FileStatus[] getFilesInPartitions() {
return new FileStatus[0];
}
String[] partitions = getOrBuildPartitionPaths().stream().map(p -> fullPartitionPath(path, p)).toArray(String[]::new);
FileStatus[] allFiles = FSUtils.getFilesInPartitions(HoodieFlinkEngineContext.DEFAULT, metadataConfig, path.toString(), partitions)
FileStatus[] allFiles = FSUtils.getFilesInPartitions(
new HoodieFlinkEngineContext(hadoopConf), metadataConfig, path.toString(), partitions)
.values().stream()
.flatMap(Arrays::stream)
.toArray(FileStatus[]::new);
Expand Down Expand Up @@ -271,7 +274,7 @@ public List<String> getOrBuildPartitionPaths() {
return this.partitionPaths;
}
List<String> allPartitionPaths = this.tableExists
? FSUtils.getAllPartitionPaths(HoodieFlinkEngineContext.DEFAULT, metadataConfig, path.toString())
? FSUtils.getAllPartitionPaths(new HoodieFlinkEngineContext(hadoopConf), metadataConfig, path.toString())
: Collections.emptyList();
if (this.partitionPruner == null) {
this.partitionPaths = allPartitionPaths;
Expand Down