[MINOR] Fixed hadoop configuration not being applied by FileIndex #8595
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
PTAL.@danny0405 |
danny0405
reviewed
May 1, 2023
| } | ||
| String[] partitions = getOrBuildPartitionPaths().stream().map(p -> fullPartitionPath(path, p)).toArray(String[]::new); | ||
| FileStatus[] allFiles = FSUtils.getFilesInPartitions(HoodieFlinkEngineContext.DEFAULT, metadataConfig, path.toString(), partitions) | ||
| FileStatus[] allFiles = FSUtils.getFilesInPartitions(hoodieFlinkEngineContext, metadataConfig, path.toString(), partitions) |
Contributor
There was a problem hiding this comment.
What kind of hadoop configuration do you wanna to pass around?
Contributor
Author
There was a problem hiding this comment.
Something like that
danny0405
reviewed
May 4, 2023
|
|
||
| private FileIndex(Path path, Configuration conf, RowType rowType, DataPruner dataPruner, PartitionPruners.PartitionPruner partitionPruner, int dataBucket) { | ||
| org.apache.hadoop.conf.Configuration hadoopConf = HadoopConfigurations.getHadoopConf(conf); | ||
|
|
Contributor
There was a problem hiding this comment.
Can we keep the hadoop conf as member instead?
Contributor
Author
There was a problem hiding this comment.
yeah, I will keep the hadoop conf as member
Contributor
Author
There was a problem hiding this comment.
I got a warning. Can we ignore it? Or do I need to make any other changes
Contributor
There was a problem hiding this comment.
Generating the HoodieFlinkEngineContext on the fly should be fine.
danny0405
approved these changes
May 4, 2023
yihua
pushed a commit
to yihua/hudi
that referenced
this pull request
May 15, 2023
…he#8595) Passed the hadoop config options from per-job to the FileIndex correctly.
yihua
pushed a commit
to yihua/hudi
that referenced
this pull request
May 15, 2023
…he#8595) Passed the hadoop config options from per-job to the FileIndex correctly.
yihua
pushed a commit
to yihua/hudi
that referenced
this pull request
May 17, 2023
…he#8595) Passed the hadoop config options from per-job to the FileIndex correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Logs
Fixed hadoop configuration not being applied by org.apache.hudi.source.FileIndex
Impact
FileIndex uses the DEFAULT HoodieFlinkEngineContext to get the partitionPath without using the information in the configuration.
Since I was connecting to a remote hadoop, I subsequently got the following error due to missing configuration
Risk level (write none, low medium or high below)
none
Documentation Update
none
Contributor's checklist