Skip to content

[HUDI-5567] Modified to make bootstrapping exception message clearer #7684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danny0405 merged 1 commit into from
Jan 31, 2023
Merged

[HUDI-5567] Modified to make bootstrapping exception message clearer #7684

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...nt/src/main/java/org/apache/hudi/client/bootstrap/HoodieSparkBootstrapSchemaProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ protected Schema getBootstrapSourceSchema(HoodieEngineContext context, List<Pair
} else if (ORC.getFileExtension().equals(extension)) {
return getBootstrapSourceSchemaOrc(writeConfig, context, filePath);
} else {
throw new HoodieException("Could not determine schema from the data files.");
throw new HoodieException("Could not determine schema from the data files, supported file formats: [ORC, PARQUET].");
}
Copy link
Copy Markdown
Contributor

@danny0405 danny0405 Jan 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could not determine schema from the data files, supported file formats: [ORC, PARQUET].

Copy link
Copy Markdown
Contributor Author

@weimingdiit weimingdiit Jan 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danny0405 thanks，danny. i have update this exception message

}
).filter(Objects::nonNull).findAny()
Expand Down Expand Up @@ -92,7 +92,7 @@ private static Schema getBootstrapSourceSchemaOrc(HoodieWriteConfig writeConfig,
try {
orcReader = OrcFile.createReader(filePath, OrcFile.readerOptions(context.getHadoopConf().get()));
} catch (IOException e) {
throw new HoodieException("Could not determine schema from the data files.");
throw new HoodieException("Could not determine schema from the ORC data files.");
}
Copy link
Copy Markdown
Contributor

@danny0405 danny0405 Jan 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could not determine schema from the ORC data files.

Copy link
Copy Markdown
Contributor Author

@weimingdiit weimingdiit Jan 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danny0405 thanks，danny. i have update this exception message

TypeDescription orcSchema = orcReader.getSchema();
String tableName = HoodieAvroUtils.sanitizeName(writeConfig.getTableName());
Expand Down