[HUDI-5567] Modified to make bootstrapping exception message clearer#7684
Merged
danny0405 merged 1 commit intoapache:masterfrom Jan 31, 2023
Merged
[HUDI-5567] Modified to make bootstrapping exception message clearer#7684danny0405 merged 1 commit intoapache:masterfrom
danny0405 merged 1 commit intoapache:masterfrom
Conversation
danny0405
reviewed
Jan 18, 2023
| } else { | ||
| throw new HoodieException("Could not determine schema from the data files."); | ||
| throw new HoodieException("Could not determine schema from the data files. Only two file types, orc and parquet, are supported."); | ||
| } |
Contributor
There was a problem hiding this comment.
Could not determine schema from the data files, supported file formats: [ORC, PARQUET].
Contributor
Author
There was a problem hiding this comment.
@danny0405 thanks，danny. i have update this exception message
danny0405
reviewed
Jan 18, 2023
| } catch (IOException e) { | ||
| throw new HoodieException("Could not determine schema from the data files."); | ||
| throw new HoodieException("Could not determine schema from the data files. Create orc reader error."); | ||
| } |
Contributor
There was a problem hiding this comment.
Could not determine schema from the ORC data files.
Contributor
Author
There was a problem hiding this comment.
@danny0405 thanks，danny. i have update this exception message
weimingdiit
force-pushed
the
HUDI-5567
branch
from
31fe16b to
5aca03f
Compare
Collaborator
danny0405
approved these changes
Jan 31, 2023
Contributor
Contributor
Author
|
@danny0405 thanks for your review danny. |
yihua
pushed a commit
that referenced
this pull request
Jan 31, 2023
fengjian428
pushed a commit
to fengjian428/hudi
that referenced
this pull request
Apr 5, 2023
…he#7684) Co-authored-by: jameswei <jameswei@didiglobal.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Logs
Exception message maybe can clearer when determine schema from the data files in bootstrap.
Impact
nothing
Risk level (write none, low medium or high below)
If medium or high, explain what verification was done to mitigate the risks.
Documentation Update
Describe any necessary documentation update if there is any new feature, config, or user-facing change
ticket number here and follow the instruction to make
changes to the website.
Contributor's checklist