Skip to content

[MINOR] Support column type evolution for Hive #7129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fsilent wants to merge 6 commits into
base: master
Choose a base branch
from
Open

[MINOR] Support column type evolution for Hive #7129

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
cbd9569
[MINOR] Support schema evolution for Hive
Nov 3, 2022
00ff1d4
[MINOR] Support column type evolution for Hive
Nov 3, 2022
e86e785
[MINOR] Support column type evolution for Hive
Nov 4, 2022
d835826
[MINOR] Support column type evolution for Hive
Nov 4, 2022
90b1fef
[MINOR] Support column type evolution for Hive
Nov 7, 2022
f6a718f
[MINOR] Support column type evolution for Hive
Nov 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/HoodieParquetInputFormat.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@

package org.apache.hudi.hadoop;

import org.apache.hadoop.hive.ql.io.SelfDescribingInputFormatInterface;
import org.apache.hadoop.hive.ql.io.sarg.ConvertAstToSearchArg;
import org.apache.hadoop.hive.ql.plan.TableScanDesc;
import org.apache.hadoop.io.ArrayWritable;
Expand Down Expand Up @@ -45,7 +46,8 @@
*/
@UseRecordReaderFromInputFormat
@UseFileSplitsFromInputFormat
public class HoodieParquetInputFormat extends HoodieParquetInputFormatBase {
public class HoodieParquetInputFormat extends HoodieParquetInputFormatBase implements
SelfDescribingInputFormatInterface {

@xiarixiaoyao xiarixiaoyao Nov 4, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it will be better to implements SelfDescribingInputFormatInterface by HoodieParquetInputFormatBase
let's move this change to HoodieParquetInputFormatBase

public abstract class HoodieParquetInputFormatBase extends MapredParquetInputFormat implements Configurable, SelfDescribingInputFormatInterface

@fsilent fsilent Nov 4, 2022

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok. has changed


private static final Logger LOG = LogManager.getLogger(HoodieParquetInputFormat.class);

Expand Down
4 changes: 3 additions & 1 deletion ...op-mr/src/main/java/org/apache/hudi/hadoop/realtime/HoodieParquetRealtimeInputFormat.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@

package org.apache.hudi.hadoop.realtime;

import org.apache.hadoop.hive.ql.io.SelfDescribingInputFormatInterface;
import org.apache.hadoop.hive.serde2.ColumnProjectionUtils;
import org.apache.hadoop.io.ArrayWritable;
import org.apache.hadoop.io.NullWritable;
Expand All @@ -42,7 +43,8 @@
*/
@UseRecordReaderFromInputFormat
@UseFileSplitsFromInputFormat
public class HoodieParquetRealtimeInputFormat extends HoodieParquetInputFormat {
public class HoodieParquetRealtimeInputFormat extends HoodieParquetInputFormat implements
SelfDescribingInputFormatInterface {

private static final Logger LOG = LogManager.getLogger(HoodieParquetRealtimeInputFormat.class);

Expand Down
14 changes: 14 additions & 0 deletions hudi-spark-datasource/hudi-spark-common/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,6 +222,20 @@
<scope>test</scope>
</dependency>

<!-- Hive -->
<dependency>

@leesf leesf Nov 3, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why we need hive dependency here?

@fsilent fsilent Nov 4, 2022

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed. now dont need to add hive dependency

@bvaradar bvaradar Mar 12, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is still showing up. Can you remove this dependency as the change is in hudi-hadoop-mr package and hive-exec is already defined as dependency in hudi-hadoop-mr /pom.xml

<groupId>${hive.groupid}</groupId>
<artifactId>hive-exec</artifactId>
<version>${hive.version}</version>
<classifier>${hive.exec.classifier}</classifier>
<exclusions>
<exclusion>
<groupId>*</groupId>
<artifactId>*</artifactId>
</exclusion>
</exclusions>
</dependency>

<!-- Hoodie - Test -->
<dependency>
<groupId>org.apache.hudi</groupId>
Expand Down