Skip to content

[MINOR] Support column type evolution for Hive #7129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fsilent wants to merge 6 commits into
base: master
Choose a base branch
from
+27 −1
Open

[MINOR] Support column type evolution for Hive #7129

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
cbd9569
[MINOR] Support schema evolution for Hive
Nov 3, 2022
00ff1d4
[MINOR] Support column type evolution for Hive
Nov 3, 2022
e86e785
[MINOR] Support column type evolution for Hive
Nov 4, 2022
d835826
[MINOR] Support column type evolution for Hive
Nov 4, 2022
90b1fef
[MINOR] Support column type evolution for Hive
Nov 7, 2022
f6a718f
[MINOR] Support column type evolution for Hive
Nov 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/HoodieParquetInputFormatBase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
import org.apache.hadoop.fs.FileStatus;
import org.apache.hadoop.fs.FileSystem;
import org.apache.hadoop.fs.Path;
import org.apache.hadoop.hive.ql.io.SelfDescribingInputFormatInterface;
import org.apache.hadoop.hive.ql.io.parquet.MapredParquetInputFormat;
import org.apache.hadoop.mapred.FileInputFormat;
import org.apache.hadoop.mapred.FileSplit;
Expand All @@ -45,7 +46,8 @@
* either {@link HoodieCopyOnWriteTableInputFormat} or {@link HoodieMergeOnReadTableInputFormat} to be supplied
* to which it delegates all of its necessary methods.
*/
public abstract class HoodieParquetInputFormatBase extends MapredParquetInputFormat implements Configurable {
public abstract class HoodieParquetInputFormatBase extends MapredParquetInputFormat implements Configurable,
SelfDescribingInputFormatInterface {

private final HoodieTableInputFormat inputFormatDelegate;

Expand Down
13 changes: 13 additions & 0 deletions hudi-spark-datasource/hudi-spark-common/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,6 +222,19 @@
<scope>test</scope>
</dependency>

<!-- Hive -->
<dependency>
Copy link
Contributor

@leesf leesf Nov 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why we need hive dependency here?

Copy link
Contributor Author

@fsilent fsilent Nov 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed. now dont need to add hive dependency

Copy link
Contributor

@bvaradar bvaradar Mar 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is still showing up. Can you remove this dependency as the change is in hudi-hadoop-mr package and hive-exec is already defined as dependency in hudi-hadoop-mr /pom.xml

<groupId>${hive.groupid}</groupId>
<artifactId>hive-exec</artifactId>
<version>${hive.version}</version>
<exclusions>
<exclusion>
<groupId>*</groupId>
<artifactId>*</artifactId>
</exclusion>
</exclusions>
</dependency>

<!-- Hoodie - Test -->
<dependency>
<groupId>org.apache.hudi</groupId>
Expand Down
11 changes: 11 additions & 0 deletions hudi-sync/hudi-hive-sync/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,17 @@
<artifactId>hive-common</artifactId>
<version>${hive.version}</version>
</dependency>
<dependency>
Copy link
Contributor

@bvaradar bvaradar Mar 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove this dependency as the change is in hudi-hadoop-mr package and hive-exec is already defined as dependency in hudi-hadoop-mr /pom.xml

<groupId>${hive.groupid}</groupId>
<artifactId>hive-exec</artifactId>
<version>${hive.version}</version>
<exclusions>
<exclusion>
<groupId>*</groupId>
<artifactId>*</artifactId>
</exclusion>
</exclusions>
</dependency>

<!-- Hoodie - Test -->
<dependency>
Expand Down