Skip to content

[HUDI-5005] Flink stream write reuse abort instant will lead to coordinator delete file not right. #6917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
TJX2014 wants to merge 1 commit into from
Closed

[HUDI-5005] Flink stream write reuse abort instant will lead to coordinator delete file not right. #6917

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/meta/CkpMetadata.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,8 +175,8 @@ public String lastPendingInstant() {
load();
if (this.messages.size() > 0) {
CkpMessage ckpMsg = this.messages.get(this.messages.size() - 1);
// consider 'aborted' as pending too to reuse the instant
if (!ckpMsg.isComplete()) {
// should not consider 'aborted', which will lead writer instant not consistent with coordinator
if (ckpMsg.isInflight()) {
return ckpMsg.getInstant();
Copy link
Contributor

@danny0405 danny0405 Oct 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We never abort a checkpoint in master code now, can you double check this logic again ?

Copy link
Contributor Author

@TJX2014 TJX2014 Oct 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, no abort in coordinator, I will check other situation of abort instant.

}
}
Expand Down