[HUDI-5005] Flink stream write reuse abort instant will lead to coordinator delete file not right. #6917
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@danny0405 Please help review this. |
danny0405
reviewed
Oct 11, 2022
| if (!ckpMsg.isComplete()) { | ||
| // should not consider 'aborted', which will lead writer instant not consistent with coordinator | ||
| if (ckpMsg.isInflight()) { | ||
| return ckpMsg.getInstant(); |
Contributor
There was a problem hiding this comment.
We never abort a checkpoint in master code now, can you double check this logic again ?
Contributor
Author
There was a problem hiding this comment.
Thanks, no abort in coordinator, I will check other situation of abort instant.
Collaborator
yihua
added
writer-core
engine:flink
Contributor
|
Close because it is invalid since #7620 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Logs
Flink writer not consider aborted instant to write because:
1.When stream write reuse aborted instant, there is chance this one is older than instant of coordinator
2.For org.apache.hudi.sink.common.AbstractStreamWriteFunction#instantToWrite, there is chance to get two different instants(the older and the new one), but only send the older to coordinator, so the coordinator think the new one is dirty and delete it, which will cause FileNotFoundException.
Impact
Bug fix.
Risk level: none | low | medium | high
none
Documentation Update
none
Contributor's checklist